Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

SP: add test for different constructor vs setter behavior #1387

Closed
wants to merge 4 commits into from
Closed

SP: add test for different constructor vs setter behavior #1387

wants to merge 4 commits into from

Commits on Jan 12, 2018

  1. SP: add test for different constructor vs setter behavior 

    SP behaves differently when constructor vs setters are used to set the
same parameters!
    @breznak
    breznak committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    aef9356 View commit details
    Browse the repository at this point in the history

  2. SP: fix setActiveColumnsPerInhArea behavior 

    this sets the num active columns,
but also has to disable mutex localAreaDensity,
according to the API it's done by = -1;
but the setter wrongly used =0;
fixed
    @breznak
    breznak committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    00b247a View commit details
    Browse the repository at this point in the history

  3. SP: add setter test for potentialRadius 

    also causes difference
    @breznak
    breznak committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    3514f27 View commit details
    Browse the repository at this point in the history

  4. SP: add bounds check for setter PotentialPct, PotentialRadius 

    this fixes the issue with different SP states when constructor/setter is used.
    @breznak
    breznak committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    d3d2a40 View commit details
    Browse the repository at this point in the history