Net6 sdk #432
Merged
Net6 sdk #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move common definitions from individual .csproj files to Directory.Build.props - Fix nullability issues. - Do what we preach, reference nunit.analyzers as an Analyzer
|
Thanks for doing this @manfred-brands. I think I'll have time to review it tonight or tomorrow. |
mikkelbu
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Looks great @manfred-brands 👍 . I only have the smallest of comments, but I'm also happy to merge it as it is.
src/nunit.analyzers.tests/TestMethodUsage/TestMethodUsageAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
src/nunit.analyzers.tests/TestMethodUsage/TestMethodUsageAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
src/nunit.analyzers.tests/Extensions/ITypeSymbolExtensionsTests.cs
Outdated
Show resolved
Hide resolved
|
Thanks @mikkelbu for your review. Changes applied, ready for merge. |
|
Thanks for the PR @manfred-brands. I'm merging it now. |
|
@manfred-brands Thanks for noticing this. I should have given it some thought when I performed the review |
|
We should also get #438 into that new release. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272
@mikkelbu this is in preparation of #416 where we need way more projects, one for every supported compiler, to prevent duplication, I moved to using the Directory.Build.props to host common definitions.