-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Net6 sdk #432
Net6 sdk #432
Conversation
- Move common definitions from individual .csproj files to Directory.Build.props - Fix nullability issues. - Do what we preach, reference nunit.analyzers as an Analyzer
Thanks for doing this @manfred-brands. I think I'll have time to review it tonight or tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @manfred-brands 👍 . I only have the smallest of comments, but I'm also happy to merge it as it is.
src/nunit.analyzers.tests/TestMethodUsage/TestMethodUsageAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
src/nunit.analyzers.tests/TestMethodUsage/TestMethodUsageAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
src/nunit.analyzers.tests/Extensions/ITypeSymbolExtensionsTests.cs
Outdated
Show resolved
Hide resolved
Thanks @mikkelbu for your review. Changes applied, ready for merge. |
Thanks for the PR @manfred-brands. I'm merging it now. |
@manfred-brands Thanks for noticing this. I should have given it some thought when I performed the review |
We should also get #438 into that new release. |
Fixes #272
@mikkelbu this is in preparation of #416 where we need way more projects, one for every supported compiler, to prevent duplication, I moved to using the Directory.Build.props to host common definitions.