NullReferenceSuppressor: Keep looking outside Assert.Multiple #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manfred-brands
force-pushed
the
issue/436_cs8604_not_suppressed
branch
from
84deb52
to
1df05f1
Compare
…er reason to suppress.
Merged
mikkelbu
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
LGTM and I find the new code a bit easier to read than the original code, so great work @manfred-brands. I'll merge it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for other reason to suppress.
Fixes #436
The problem was not the Has.Count.
This was considered a suppressible line, but as it was inside the Assert.Multiple it was ignored.
It should have looked further to find the Is.Not.Null.