[Lim Rui Ting Valencia] iP #608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature
ValenciaLim
changed the title
TaskSerialiser lacks assertions to ensure that task exist in order to serialise task into string and parse string back into task. StorageManager lacks assertions to ensure that save path exists before attempting to save to directory and load from directory. Assert statements are added to the TaskSerializer class to check for null inputs, as well as StorageManager class to check for empty save path. Adding assertions allows us to catch potential issues early in the development process, reducing the likelihood of introducing bugs into the codebase.
Compare branch-A-Assertions and master
Parser class: create functions to check for null task number and blank fields. Null task number and blank fields are handled in multiple switch cases, causing code duplication. Extracting the common error handling into its corresponding function allow us to reuse the code more efficiently. This also reduces the number of lines the parseCommand method have. Error handling for null task number is written in the checkNullTaskNum function. Error handling for blank fields i.e. descriptions, due date, start date, end date, keyword are written in the checkBlankField function.
Complete A-CodeQuality
Tasklist add() method: check for duplicate tasks and overlapping events before adding to tasklist. DialogBox and MainWindow: change design of the error message to highlight errors, allow resizing of window, make profile pictures smaller and add circle border around it.
Tasklist add() method: check for duplicate tasks and overlapping events before adding to tasklist. Use of Apache Common Lang Library to make descriptions insensitive to additional whitespaces and lack of whitespace. DialogBox and MainWindow: change design of the error message to highlight errors, allow resizing of window, make profile pictures smaller and add circle border around it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cal
Introducing Cal, your very own secretary that remembers your task for you! 😉 It's
FASTSUPER FAST to useChat with Cal and he will help you to keep track of:
And it is FREE!
Features:
Get Started
java -jar cal.jarIf you are a Java programmer, you can use it to practice Java too. Here's the
mainmethod: