Add support for Kubernetes v1.29 clusters #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
nutanix-cn-prow-bot
bot
requested review from
deepakm-ntnx and
yannickstruyf3
|
could you please also add references on why these changes are required, may be a ref to opensource link on these suggestions |
|
/test e2e-capx-controller-upgrade |
|
/test e2e-k8s-upgrade |
1 similar comment
|
/test e2e-k8s-upgrade |
|
/test e2e-capx-conformance |
3 similar comments
|
/test e2e-capx-conformance |
|
/test e2e-capx-conformance |
|
/test e2e-capx-conformance |
|
Seems, the conformance jobs are consecutively failing on the CSI job. |
|
/test e2e-capx-conformance |
|
/test e2e-capx-controller-upgrade |
|
/test e2e-capx-conformance |
4 similar comments
|
/test e2e-capx-conformance |
|
/test e2e-capx-conformance |
|
/test e2e-capx-conformance |
|
/test e2e-capx-conformance |
This required two changes:
- Remove hostAliases from kube-vip podspec
This is addressed by adding entries directly to the /etc/hosts
- Do a super-admin.conf switcheroo for the kube-vip static pod
Add pre and post kubeadm commands for handling kubernetes
versions v1.29.0+. The prekubeadm command checks if kubeadm
init has been run and if it is, it replaces the kubeconfig
hostPath in kube-vip static pod from admin.conf to the
super-admin.conf. The postkubeadm command checks if
kubeadm init has been run and if it is, it changes the
hostPath in kube-vip static pod from super-admin.conf
back to admin.conf.
thunderboltsid
force-pushed
the
jira/krbn-8029
branch
from
ab65e15 to
d5ff104
Compare
|
/retest |
|
/test e2e-capx-conformance |
3 similar comments
|
/test e2e-capx-conformance |
|
/test e2e-capx-conformance |
|
/test e2e-capx-conformance |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
=======================================
Coverage 20.37% 20.37%
=======================================
Files 17 17
Lines 1212 1212
=======================================
Hits 247 247
Misses 965 965 ☔ View full report in Codecov by Sentry. |
deepakm-ntnx
approved these changes
Feb 27, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepakm-ntnx, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jimmidyson
reviewed
Feb 29, 2024
dkoshkin
reviewed
Mar 1, 2024
dkoshkin
approved these changes
Mar 4, 2024
thunderboltsid
added a commit
that referenced
this pull request
Mar 13, 2024
This required two changes:
- Remove hostAliases from kube-vip podspec
This is addressed by adding entries directly to the /etc/hosts
- Do a super-admin.conf switcheroo for the kube-vip static pod
Add pre and post kubeadm commands for handling kubernetes
versions v1.29.0+. The prekubeadm command checks if kubeadm
init has been run and if it is, it replaces the kubeconfig
hostPath in kube-vip static pod from admin.conf to the
super-admin.conf. The postkubeadm command checks if
kubeadm init has been run and if it is, it changes the
hostPath in kube-vip static pod from super-admin.conf
back to admin.conf.
thunderboltsid
added a commit
that referenced
this pull request
Mar 13, 2024
This required two changes:
- Remove hostAliases from kube-vip podspec
This is addressed by adding entries directly to the /etc/hosts
- Do a super-admin.conf switcheroo for the kube-vip static pod
Add pre and post kubeadm commands for handling kubernetes
versions v1.29.0+. The prekubeadm command checks if kubeadm
init has been run and if it is, it replaces the kubeconfig
hostPath in kube-vip static pod from admin.conf to the
super-admin.conf. The postkubeadm command checks if
kubeadm init has been run and if it is, it changes the
hostPath in kube-vip static pod from super-admin.conf
back to admin.conf.
thunderboltsid
added a commit
that referenced
this pull request
Mar 13, 2024
This required two changes:
- Remove hostAliases from kube-vip podspec
This is addressed by adding entries directly to the /etc/hosts
- Do a super-admin.conf switcheroo for the kube-vip static pod
Add pre and post kubeadm commands for handling kubernetes
versions v1.29.0+. The prekubeadm command checks if kubeadm
init has been run and if it is, it replaces the kubeconfig
hostPath in kube-vip static pod from admin.conf to the
super-admin.conf. The postkubeadm command checks if
kubeadm init has been run and if it is, it changes the
hostPath in kube-vip static pod from super-admin.conf
back to admin.conf.
thunderboltsid
added a commit
that referenced
this pull request
Mar 13, 2024
This required two changes:
- Remove hostAliases from kube-vip podspec
This is addressed by adding entries directly to the /etc/hosts
- Do a super-admin.conf switcheroo for the kube-vip static pod
Add pre and post kubeadm commands for handling kubernetes
versions v1.29.0+. The prekubeadm command checks if kubeadm
init has been run and if it is, it replaces the kubeconfig
hostPath in kube-vip static pod from admin.conf to the
super-admin.conf. The postkubeadm command checks if
kubeadm init has been run and if it is, it changes the
hostPath in kube-vip static pod from super-admin.conf
back to admin.conf.
thunderboltsid
added a commit
that referenced
this pull request
Mar 13, 2024
This required two changes:
- Remove hostAliases from kube-vip podspec
This is addressed by adding entries directly to the /etc/hosts
- Do a super-admin.conf switcheroo for the kube-vip static pod
Add pre and post kubeadm commands for handling kubernetes
versions v1.29.0+. The prekubeadm command checks if kubeadm
init has been run and if it is, it replaces the kubeconfig
hostPath in kube-vip static pod from admin.conf to the
super-admin.conf. The postkubeadm command checks if
kubeadm init has been run and if it is, it changes the
hostPath in kube-vip static pod from super-admin.conf
back to admin.conf.
thunderboltsid
added a commit
that referenced
this pull request
Mar 13, 2024
* Add support for Kubernetes v1.29 clusters (#382) This required two changes: - Remove hostAliases from kube-vip podspec This is addressed by adding entries directly to the /etc/hosts - Do a super-admin.conf switcheroo for the kube-vip static pod Add pre and post kubeadm commands for handling kubernetes versions v1.29.0+. The prekubeadm command checks if kubeadm init has been run and if it is, it replaces the kubeconfig hostPath in kube-vip static pod from admin.conf to the super-admin.conf. The postkubeadm command checks if kubeadm init has been run and if it is, it changes the hostPath in kube-vip static pod from super-admin.conf back to admin.conf. * Update controller-gen version to 0.14.0 and update makefile Go1.22 broke controller-gen version 0.8.0 through 0.13.0. Go1.22 drops support for GO111MODULE=off go get -u in legacy gopath mode.
thunderboltsid
added a commit
that referenced
this pull request
Apr 25, 2024
This required two changes:
- Remove hostAliases from kube-vip podspec
This is addressed by adding entries directly to the /etc/hosts
- Do a super-admin.conf switcheroo for the kube-vip static pod
Add pre and post kubeadm commands for handling kubernetes
versions v1.29.0+. The prekubeadm command checks if kubeadm
init has been run and if it is, it replaces the kubeconfig
hostPath in kube-vip static pod from admin.conf to the
super-admin.conf. The postkubeadm command checks if
kubeadm init has been run and if it is, it changes the
hostPath in kube-vip static pod from super-admin.conf
back to admin.conf.
thunderboltsid
added a commit
that referenced
this pull request
Apr 26, 2024
This required two changes:
- Remove hostAliases from kube-vip podspec
This is addressed by adding entries directly to the /etc/hosts
- Do a super-admin.conf switcheroo for the kube-vip static pod
Add pre and post kubeadm commands for handling kubernetes
versions v1.29.0+. The prekubeadm command checks if kubeadm
init has been run and if it is, it replaces the kubeconfig
hostPath in kube-vip static pod from admin.conf to the
super-admin.conf. The postkubeadm command checks if
kubeadm init has been run and if it is, it changes the
hostPath in kube-vip static pod from super-admin.conf
back to admin.conf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required two changes:
How has this been tested?
Create a cluster with Kubernetes v1.29.2
and see the cluster come up