Cherry-pick PR #382 to release-v1.3 #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderboltsid
force-pushed
the
jira/krbn-8081
branch
2 times, most recently
from
cf8bdb8 to
2231a5e
Compare
thunderboltsid
force-pushed
the
jira/krbn-8081
branch
from
2231a5e to
6243728
Compare
This required two changes:
- Remove hostAliases from kube-vip podspec
This is addressed by adding entries directly to the /etc/hosts
- Do a super-admin.conf switcheroo for the kube-vip static pod
Add pre and post kubeadm commands for handling kubernetes
versions v1.29.0+. The prekubeadm command checks if kubeadm
init has been run and if it is, it replaces the kubeconfig
hostPath in kube-vip static pod from admin.conf to the
super-admin.conf. The postkubeadm command checks if
kubeadm init has been run and if it is, it changes the
hostPath in kube-vip static pod from super-admin.conf
back to admin.conf.
thunderboltsid
force-pushed
the
jira/krbn-8081
branch
from
6243728 to
3e2240b
Compare
|
Need to wait for #391 to merge to unblock the broken CI Pipeline |
|
/hold |
yannickstruyf3
previously approved these changes
Mar 13, 2024
Go1.22 broke controller-gen version 0.8.0 through 0.13.0. Go1.22 drops support for GO111MODULE=off go get -u in legacy gopath mode.
thunderboltsid
force-pushed
the
jira/krbn-8081
branch
from
4f0df6b to
d9bf60a
Compare
✅ None of your dependencies violate policy! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v1.3 #390 +/- ##
================================================
- Coverage 12.53% 12.18% -0.35%
================================================
Files 20 21 +1
Lines 2003 2060 +57
================================================
Hits 251 251
- Misses 1752 1809 +57 ☔ View full report in Codecov by Sentry. |
|
/retest |
|
/hold cancel |
yannickstruyf3
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-Pick Details
This PR also merges commits from #391 as E2Es won't pass without Kubernetes 1.29 support on that PR and unit tests on this PR won't pass without changes in that PR.