Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow installing on node v18 #374

Merged
merged 3 commits into from
Jul 1, 2022
Merged

fix: allow installing on node v18 #374

merged 3 commits into from
Jul 1, 2022

Conversation

dargmuesli
Copy link
Member

@dargmuesli dargmuesli commented Jun 24, 2022 •
edited
Loading

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Node 18 is out since 2022-04-19: https://nodejs.org/en/about/releases/
#373

Depends on #324

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

pi0
pi0 reviewed Jun 24, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dargmuesli
Revert "ci(node): use v18"
d79ee4f 
This reverts commit 3155e24.
danielroe
danielroe approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danielroe danielroe changed the title feat(node): allow v18 fix: allow installing on node v18 Jul 1, 2022
@danielroe danielroe merged commit 8000144 into nuxt:main Jul 1, 2022
@dargmuesli dargmuesli deleted the feat/node-18 branch July 1, 2022 17:05
@danielroe danielroe mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 left review comments

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dargmuesli @pi0 @danielroe