-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: upgrade nitropack #324
Conversation
@pi0, what about this PR? If you accept it, it will be great, please! πβ€οΈ |
Hey @danielroe, can we help somehow to get this done? |
@danielroe is also maintainer of this repo :) There is no need for my approval ππΌ |
Yes, this is my delay, not @pi0's! Feel free to ping me on Discord and we can chat π |
@danielroe Is there any ETA for #32 issue because we need .html for deployment. |
This comment was marked as off-topic.
This comment was marked as off-topic.
f4e8601
to
5104137
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only difference in output for me is now - kind of obviously - that the sitemap, robots and i18n modules' outputs are missing now. Otherwise it works great!
@dargmuesli Were you able to test nuxt route middleware?
|
Alright, I will check the other 2 issues I currently have after the PR has been merged. |
In case anyone else wants to test this fix too for their project, here are the steps to do so in your project:
I'd be fine with a soon merge of this PR of course. I can't imagine it breaking more than what already broke? π€ |
@danielroe you write
Would you mind explaining the reason why that is recommended? I suppose |
pending @antfu fix
It's likely there are remaining issues, but I think this PR is sufficient to enable us to test and iterate with edge releases. Thank you to everyone who has tested it so far - please let me know in a new issue if you are experiencing any issues β€οΈ |
@dargmuesli Without |
π Linked issue
resolves #322, resolves #31, resolves #32, resolves #375, resolves #356
β Type of change
π Description
This upgrades nitropack which should fix a few issues on the books at the moment.
Also note #316 which could be combined with this one.Breaking change:
nuxi generate
now behaves differently using nitro prerendering instead of the Nuxt 2 full-static approach. If you would like to keep the Nuxt 2 generation logic while still usingnitro
, you can runnuxi generate --classic
or setbridge.nitroGenerator
.Progress:
nuxi generate
prerendering - ssr & spaπ Migration
If you would like to keep the Nuxt 2 generation logic while still using
nitro
, you can runnuxi generate --classic
or setbridge.nitroGenerator
.π Checklist