Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

refactor(nuxt): enable strict type checking #6368

Merged
merged 21 commits into from
Aug 12, 2022
Merged

refactor(nuxt): enable strict type checking #6368

merged 21 commits into from
Aug 12, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Aug 4, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The first step migrating the entire repo to strict: true

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 4, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 2a04510
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62f68fe0e4bdba0009e1f9a5

packages/nuxt/src/app/entry.ts Outdated Show resolved Hide resolved
@antfu antfu marked this pull request as draft August 4, 2022 16:35
packages/nuxt/src/core/app.ts Outdated Show resolved Hide resolved
@antfu antfu marked this pull request as ready for review August 10, 2022 15:03
@pi0
Copy link
Member

pi0 commented Aug 12, 2022

This is a nice initiative πŸš€ Merging to avoid stalling PR. There has been some leftovers also in packages/nuxt which we can improve type coverage and fix errors.

I've triple checked but there might be regressions with changes. /cc @danielroe heads up

@antfu Can we please allow unplugin define to make input options mandatory? It can help to properly type them. πŸ™πŸΌ

@pi0 pi0 changed the title chore: enable ts strict for packages/nuxt refactor(nuxt): enable strict type checking Aug 12, 2022
@pi0 pi0 merged commit f350a70 into main Aug 12, 2022
@pi0 pi0 deleted the chore/strict branch August 12, 2022 17:47
@antfu
Copy link
Member Author

antfu commented Aug 15, 2022

@pi0 Published unplugin@0.9.1 support required options

@pi0 pi0 mentioned this pull request Aug 26, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants