Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use libgrpc=1.54 #353

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Use libgrpc=1.54 #353

merged 4 commits into from
Jul 12, 2023

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Jul 11, 2023 •
edited
Loading

closes #352

@cwharris cwharris added non-breaking Non-breaking change feature request New feature or request conda-build Enables running the conda-build step on a PR labels Jul 11, 2023
@cwharris cwharris requested a review from a team as a code owner July 11, 2023 15:17
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #353 (0a8a0fb) into branch-23.07 (92aa21a) will decrease coverage by 0.10%.
The diff coverage is 85.30%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.07     #353      +/-   ##
================================================
- Coverage         73.24%   73.14%   -0.10%     
================================================
  Files               390      382       -8     
  Lines             13380    13403      +23     
  Branches           1010     1011       +1     
================================================
+ Hits               9800     9804       +4     
- Misses             3580     3599      +19
Flag Coverage Δ
cpp 69.07% <80.16%> (-0.01%) ⬇️
py 42.06% <66.43%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/include/mrc/core/task_queue.hpp 94.73% <ø> (ø)
cpp/mrc/include/mrc/manifold/connectable.hpp 100.00% <ø> (ø)
.../mrc/include/mrc/memory/resources/detail/arena.hpp 72.48% <0.00%> (ø)
cpp/mrc/include/mrc/modules/segment_modules.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/node/rx_node.hpp 93.47% <ø> (+9.38%) ⬆️
cpp/mrc/include/mrc/runnable/engine_factory.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/runnable/runner.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/segment/object.hpp 51.45% <ø> (ø)
cpp/mrc/src/internal/codable/codable_storage.cpp 37.23% <ø> (ø)
...rc/src/internal/codable/decodable_storage_view.cpp 24.52% <ø> (ø)
... and 157 more

... and 22 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782a4f3...0a8a0fb. Read the comment docs.

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 7345aa6 into nv-morpheus:branch-23.07 Jul 12, 2023
12 checks passed
@mdemoret-nv mdemoret-nv mentioned this pull request Jul 13, 2023
Merged
rapids-bot bot pushed a commit to nv-morpheus/Morpheus that referenced this pull request Jul 13, 2023
@mdemoret-nv
Changing GRPC requirement from grpc-cpp to libgrpc (#1056)
2f52c0e 
To work with the change from MRC PR nv-morpheus/MRC#353, we need to use `libgrpc` instead of `grpc-cpp` in our conda environments since they changed the package name.

Authors:
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Devin Robison (https://github.com/drobison00)

URL: #1056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@cwharris cwharris

Labels
conda-build Enables running the conda-build step on a PR feature request New feature or request non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Upgrade to gRPC 1.53
2 participants
@cwharris @mdemoret-nv