Skip to content

Commit

Permalink
Move data dir to models (#1099)
Browse files Browse the repository at this point in the history
* Move `morpheus/data` to `models/data`
* Replace `morpheus/data` with a symlink to `models/data`
* Newly built CI images to fix #1100

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1099
  • Loading branch information
dagardner-nv authored Jul 25, 2023
1 parent f6ca8e1 commit 96f8df0
Show file tree
Hide file tree
Showing 24 changed files with 12 additions and 11 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
uses: ./.github/workflows/ci_pipe.yml
with:
run_check: ${{ startsWith(github.ref_name, 'pull-request/') }}
container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-build-230710
test_container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-test-230710
container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-build-230725
test_container: nvcr.io/ea-nvidia-morpheus/morpheus:morpheus-ci-test-230725
secrets:
NGC_API_KEY: ${{ secrets.NGC_API_KEY }}
2 changes: 1 addition & 1 deletion ci/scripts/run_ci_local.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ GIT_BRANCH=$(git branch --show-current)
GIT_COMMIT=$(git log -n 1 --pretty=format:%H)

LOCAL_CI_TMP=${LOCAL_CI_TMP:-${MORPHEUS_ROOT}/.tmp/local_ci_tmp}
CONTAINER_VER=${CONTAINER_VER:-230710}
CONTAINER_VER=${CONTAINER_VER:-230725}
CUDA_VER=${CUDA_VER:-11.8}
DOCKER_EXTRA_ARGS=${DOCKER_EXTRA_ARGS:-""}

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
1 change: 1 addition & 0 deletions morpheus/data
6 changes: 3 additions & 3 deletions tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ def test_pipeline_nlp(self, config, callback_values):
assert isinstance(deserialize, DeserializeStage)

assert isinstance(process_nlp, PreprocessNLPStage)
assert process_nlp._vocab_hash_file == vocab_file_name
assert process_nlp._vocab_hash_file == os.path.realpath(vocab_file_name)
assert process_nlp._truncation
assert process_nlp._do_lower_case
assert not process_nlp._add_special_tokens
Expand Down Expand Up @@ -838,7 +838,7 @@ def test_pipeline_nlp_all(self, config, callback_values, tmp_path, mlflow_uri):
assert dropna._column == 'xyz'

assert isinstance(process_nlp, PreprocessNLPStage)
assert process_nlp._vocab_hash_file == vocab_file_name
assert process_nlp._vocab_hash_file == os.path.realpath(vocab_file_name)
assert process_nlp._truncation
assert process_nlp._do_lower_case
assert not process_nlp._add_special_tokens
Expand Down Expand Up @@ -927,7 +927,7 @@ def test_pipeline_nlp_relative_paths(self, config, callback_values):
# pylint: disable=unused-variable
[file_source, deserialize, process_nlp, triton_inf, monitor, add_class, validation, serialize, to_file] = stages

assert process_nlp._vocab_hash_file == vocab_file_name
assert process_nlp._vocab_hash_file == os.path.realpath(vocab_file_name)

@pytest.mark.replace_callback('pipeline_nlp')
def test_pipeline_nlp_relative_path_precedence(self, config, callback_values, tmp_path):
Expand Down

0 comments on commit 96f8df0

Please sign in to comment.