-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move data dir to models #1099
Move data dir to models #1099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets wait for confirmation from packaging that this looks good before merging
@mdemoret-nv @dagardner-nv does this look right?
|
@pdmack we moved the data dir to When we perform an install setuptools follows the symlink and copies the actual files into site-packages. What you are seeing is that if you use the
@mdemoret-nv and I talked about this and we wanted to come up with something that would work for both users in a bare-metal install, a local docker build or a container downloaded from NGC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/merge |
Description
morpheus/data
tomodels/data
morpheus/data
with a symlink tomodels/data
Checklist