Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] CI scripts broken #114

Closed
dagardner-nv opened this issue May 18, 2022 · 0 comments · Fixed by #107
Closed

[BUG] CI scripts broken #114

dagardner-nv opened this issue May 18, 2022 · 0 comments · Fixed by #107
Assignees
@dagardner-nv
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Describe the bug
Both ci/scripts/python_checks.sh and ci/scripts/fix_all.sh are currently broken.
I believe python_checks might be working when invoked as a git hook and I have a pull-req open which fixes it in CI, but these should work when invoker directly.

Steps/Code to reproduce bug
ci/scripts/python_checks.sh

Environment overview (please complete the following information)

  • Environment location: Bare-metal
  • Method of Morpheus install: from source
@dagardner-nv dagardner-nv added bug Something isn't working Needs Triage Need team to review and classify and removed Needs Triage Need team to review and classify labels May 18, 2022
@dagardner-nv dagardner-nv self-assigned this May 18, 2022
@dagardner-nv dagardner-nv mentioned this issue May 20, 2022
Merged
@ghost ghost closed this as completed in #107 Jun 8, 2022
ghost pushed a commit that referenced this issue Jun 8, 2022
@dagardner-nv
Jenkins improvememts (#107)
fc243ce 
+ Performs a non-inplace morpheus build.
+ Adds $ORIGIN to rpath of build binaries, fixing issue where libmorpheus.so was unable to find libmorpheus-utils.so (fixes #111 )
+ ~~Removes the need for a gpu for the build stage~~ Blocked by Neo/nvml issue #186
+ Common operations moved to common.sh
+ Fixes ci scripts so that they work locally (fixes #114 )
+ Improve the way sccache is configured (fixes #110 )

This pull req incorporates changes from #62

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Devin Robison (https://github.com/drobison00)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #107
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jenkins improvememts dagardner-nv/Morpheus
1 participant
@dagardner-nv