Ensure default path values in morpheus.cli are no longer relative #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
requested review from
BartleyR,
mdemoret-nv,
pdmack,
bsuryadevara,
drobison00,
efajardo-nv and
cwharris
as code owners
cwharris
reviewed
Apr 29, 2022
cwharris
requested changes
Apr 29, 2022
…e build, since we only generate them when doing an inplace build
…unclear on this, but the internet seems to imply that either include_package_data+MANIFEST.in or package_data should be used but not both
|
mostly LGTM, just had a few questions. |
Co-authored-by: Christopher Harris <xixonia@gmail.com>
Merged
mdemoret-nv
requested changes
May 23, 2022
…s into david-cli-rel-paths
|
@gpucibot merge |
ghost
merged commit 
This was referenced Jun 6, 2022
ghost
pushed a commit
that referenced
this pull request
Jun 7, 2022
Brings directory size down to 1.6MB down from 270MB + Move large files to `exaples/data` + Migrate existing files in `exaples/data` to git-lfs + Add missing `email_with_addresses.jsonlines` needed for phishing detection developer guide + Update file paths in docs for data files + Update import paths in developer guide Depends on changes in ~~#62~~ Fixes #120 Authors: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - https://github.com/raykallen - Michael Demoret (https://github.com/mdemoret-nv) URL: #130
ghost
pushed a commit
that referenced
this pull request
Jun 8, 2022
+ Performs a non-inplace morpheus build. + Adds $ORIGIN to rpath of build binaries, fixing issue where libmorpheus.so was unable to find libmorpheus-utils.so (fixes #111 ) + ~~Removes the need for a gpu for the build stage~~ Blocked by Neo/nvml issue #186 + Common operations moved to common.sh + Fixes ci scripts so that they work locally (fixes #114 ) + Improve the way sccache is configured (fixes #110 ) This pull req incorporates changes from #62 Authors: - David Gardner (https://github.com/dagardner-nv) - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - Devin Robison (https://github.com/drobison00) - Michael Demoret (https://github.com/mdemoret-nv) URL: #107
ghost
pushed a commit
that referenced
this pull request
Jun 15, 2022
data dir is now underneath ./morpheus Relates to #62 Authors: - Pete MacKinnon (https://github.com/pdmack) Approvers: - Christopher Harris (https://github.com/cwharris) - Michael Demoret (https://github.com/mdemoret-nv) URL: #141
ghost
pushed a commit
that referenced
this pull request
Jun 17, 2022
data dir has been relocated Relates to #62 and #141 Authors: - Pete MacKinnon (https://github.com/pdmack) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #142
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
datadir under the morpheus dir. This allows it to be easily installable via setuptools & discoverable relative tomorpheus.__file__and sets a new attributemorpheus.DATA_DIR.This change also fixes a few random bugs related to non-inplace morpheus builds.
Allows morphues cli to be run are outside of the root of the repo
fixes #60