Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFP Model Card ++ #1006

Merged
merged 4 commits into from
Jun 29, 2023
Merged

DFP Model Card ++ #1006

merged 4 commits into from
Jun 29, 2023

Conversation

hsin-c
Copy link
Contributor

@hsin-c hsin-c commented Jun 28, 2023 •
edited
Loading

Description

Adding DFP model card ++

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@hsin-c hsin-c requested a review from a team as a code owner June 28, 2023 02:01
@hsin-c hsin-c self-assigned this Jun 28, 2023
raykallen
raykallen approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@raykallen raykallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending addition of faker package link

models/model-cards/dfp-model-card.md Outdated Show resolved Hide resolved
@raykallen raykallen added doc Improvements or additions to documentation 4 - Waiting on Author labels Jun 28, 2023
@raykallen raykallen linked an issue Jun 28, 2023 that may be closed by this pull request
[DOC]: Update Model Cards to Model Card ++ format #991
Closed
10 tasks
@hsin-c hsin-c mentioned this pull request Jun 29, 2023
Closed
3 tasks
@raykallen
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 50bb74d into nv-morpheus:branch-23.07 Jun 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raykallen raykallen raykallen approved these changes

Assignees

@hsin-c hsin-c

Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC]: Update Model Cards to Model Card ++ format
2 participants
@hsin-c @raykallen