Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modelcard ++ updates #1009

Closed
wants to merge 4 commits into from
Closed

Conversation

gbatmaz
Copy link
Contributor

@gbatmaz gbatmaz commented Jun 28, 2023

Modelcard ++ updates for

  • Phishing
  • ABP
  • Root Cause

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

modelcard ++ updates for 
phishing
ABP
Root Cause
@gbatmaz gbatmaz added enhancement Additional functionality added to an existing feature non-breaking Non-breaking change improvement Improvement to existing functionality 3 - Ready for Review Data Science labels Jun 28, 2023
@gbatmaz gbatmaz requested a review from a team as a code owner June 28, 2023 16:37
@hsin-c
Copy link
Contributor

hsin-c commented Jun 29, 2023

Can we create individual model card files for each pretrained model and put them in a new model-card folder under models/?
Like what's done for the DFP model card: #1006

2. Devlin J. et al. (2018), BERT: Pre-training of Deep Bidirectional Transformers for Language Understanding https://arxiv.org/abs/1810.04805 <br>

## Model Architecture:
**Architecture Type:** Transformers <br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall comment: Can we add a bullet point (* ) to all the answers in this model card (if they do not already have one)?
It'll help the readability of the model card (and will make it prettier in .md).

@gbatmaz gbatmaz changed the title [Review] modelcard ++ updates modelcard ++ updates Jun 29, 2023
@gbatmaz gbatmaz marked this pull request as draft June 29, 2023 20:37
@gbatmaz gbatmaz closed this Jun 29, 2023
@gbatmaz gbatmaz deleted the modelcard++ branch June 29, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Science enhancement Additional functionality added to an existing feature improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants