Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example imports after python package reorg #105

Conversation

efajardo-nv
Copy link
Contributor

Few more imports in following examples needed updating after python package reorg (#98).

  • log parsing
  • abp pcap detection

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change 3 - Ready for Review labels May 13, 2022
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to resolve the merge conflicts and I think its ready to go.

@pdmack
Copy link
Contributor

pdmack commented Jun 6, 2022

@efajardo-nv kind of looks like (to my naked eye) @dagardner-nv fixed these in #62 ?

@efajardo-nv
Copy link
Contributor Author

Yep, thanks @pdmack. Closing.

@efajardo-nv efajardo-nv closed this Jun 6, 2022
@efajardo-nv efajardo-nv deleted the update-example-imports branch June 6, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants