Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issues & tests #966

Merged
merged 6 commits into from
Jun 6, 2023
Merged

Fix build issues & tests #966

merged 6 commits into from
Jun 6, 2023
+17 −4

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jun 5, 2023 •
edited
Loading

Description

  • Restore pin for camouglage v0.9 in Dockerfile, newer versions are incompat
  • Skip tests for morpheus.utils.downloader when dask.distributed is not installed.
  • Install cuda-toolkit not cudatoolkit

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner June 5, 2023 17:52
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change 3 - Ready for Review labels Jun 5, 2023
@dagardner-nv dagardner-nv changed the title Fix tests on fresh installs Fix build issues & tests Jun 5, 2023
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 982749f into nv-morpheus:branch-23.07 Jun 6, 2023
@efajardo-nv efajardo-nv mentioned this pull request Jun 7, 2023
Merged
rapids-bot bot pushed a commit that referenced this pull request Jun 12, 2023
@efajardo-nv
Update to cuda-toolkit in release container build (#974)
f109e2b 
PR #966 fixes new conda environment and dev container builds by replacing `cudatoolkit` with `cuda-toolkit`. This PR does the same to fix the release container build error in issue #973. Updates the conda recipe to use `cuda-toolkit`.

Fixes #973

Authors:
  - Eli Fajardo (https://github.com/efajardo-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efajardo-nv efajardo-nv efajardo-nv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagardner-nv @efajardo-nv