Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cuda-toolkit in release container build #974

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Jun 7, 2023

Description

PR #966 fixes new conda environment and dev container builds by replacing cudatoolkit with cuda-toolkit. This PR does the same to fix the release container build error in issue #973. Updates the conda recipe to use cuda-toolkit.

Fixes #973

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels Jun 7, 2023
@efajardo-nv efajardo-nv requested a review from a team as a code owner June 7, 2023 18:06
@efajardo-nv efajardo-nv changed the title Update to cuda-toolkit in release container Update to cuda-toolkit in release container build Jun 7, 2023
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. But should go in after we can test with changes from https://github.com/nv-morpheus/MRC/pull/320/files

@mdemoret-nv
Copy link
Contributor

Tested a release build locally and everything looks good with the latest version of MRC.

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit f109e2b into nv-morpheus:branch-23.07 Jun 12, 2023
@efajardo-nv efajardo-nv deleted the release-container-cuda-toolkit-fix branch July 29, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Release container build fails
3 participants