Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting bug-fix / maintenance PR's only while addressing backlog #11006

Closed
feerrenrut opened this issue Apr 14, 2020 · 5 comments
Closed

Accepting bug-fix / maintenance PR's only while addressing backlog #11006

feerrenrut opened this issue Apr 14, 2020 · 5 comments

Comments

@feerrenrut
Copy link
Contributor

feerrenrut commented Apr 14, 2020

NV Access would like to kindly ask contributors to temporarily hold off on creating new Pull Requests (PR's) specifically for features or enhancements to NVDA. This will be a temporary arrangement to free us up while we go through the process of addressing the existing backlog of Pull Requests. Many of the outstanding PR's will require significant time to understand, update, test and review for merging. Given that many PR's were initially created long ago, it is easily understandable why many of these are out of date or the author no longer has time to work on them.

Why we think a large backlog of PR's is undesirable:

  • Increased risk of missing important bug fixes.
  • Harder to manage incoming PR's, they easily get out of date.
  • Wastes time for contributors, keeping the PR up to date until we have a chance to consider it.
  • It's a bad look for the project, it may give the impression the project is no longer active.
  • Finally, it wastes time for NV Access, preventing us from getting to other important projects.

What the community can do:

  • Contributors to please put your efforts towards existing PR's. Many need updating and testing. Effort to make these PR's as easy to understand as possible will significantly help to speed up this process.
  • Look at issues linked to the existing PR's, see if the problems they describe are still reproducible.
  • Continue to contribute (high priority) bug fixes or maintenance pull requests, we will continue to accept these. To avoid having your Pull Request closed, please contact us before starting work if you are uncertain how we will categorize it. To help understand our categorization, all existing PR's have been labelled as either bug, maintenance, enhancement, or feature.

Our goal is to get our list of non-draft unblocked PR's down to just a handful of the newest issues

Thanks for your patience.

@feerrenrut feerrenrut pinned this issue Apr 14, 2020
@LeonarddeR
Copy link
Collaborator

Is this issue still relevant as of today?

@cary-rowen
Copy link
Contributor

I hope to see further development of NVDA, and the GSOC19 list hopes to be realized soon

@seanbudd
Copy link
Member

seanbudd commented Jul 6, 2021

Is this issue still relevant as of today?

NV Access feels like it is appropriate to lift this freeze now as the backlog has been somewhat reduced, and is unlikely to shrink much further in the near future.

@seanbudd seanbudd closed this as completed Jul 6, 2021
@seanbudd seanbudd unpinned this issue Jul 6, 2021
@ExpandingS
Copy link

ExpandingS commented Oct 23, 2021

Seeing as this has been resolved, should the notice be removed from the contributing page?

@seanbudd
Copy link
Member

Thanks @ExpandingS - I've updated that page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants