Don't activate Say All profile if there is nothing to read #11453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10899
Fixes #9947 completely
Summary of the issue:
In Python 3 versions of NVDA when user attempted to perform Say All in non text and had separate profile for Say All the profile was activated without possibility of disabling unless NVDA is restarted. Also Say All in non text raised an error. (#10723 attempted to fix this but the fix was not complete).
Description of how this pull request fixes the issue:
The say all trigger is only entered if there is something to read. Normally the destructor is responsible for disabling this trigger when reading ends but due to #9947 this was not happening.
Testing performed:
Known issues with pull request:
Change log entry:
Section: Bug fixes
NVDA no longer activates Say All profile if there is nothing to read.