Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't activate Say All profile if there is nothing to read #11453

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

lukaszgo1
Copy link
Contributor

Link to issue number:

Fixes #10899
Fixes #9947 completely

Summary of the issue:

In Python 3 versions of NVDA when user attempted to perform Say All in non text and had separate profile for Say All the profile was activated without possibility of disabling unless NVDA is restarted. Also Say All in non text raised an error. (#10723 attempted to fix this but the fix was not complete).

Description of how this pull request fixes the issue:

The say all trigger is only entered if there is something to read. Normally the destructor is responsible for disabling this trigger when reading ends but due to #9947 this was not happening.

Testing performed:

  1. On desktop pressed NVDA + Down arrow ensured that there is no error sound.
  2. With profile for Say all ensured that NVDA does not switch into it when there is not text to read and that it switches to it when performing say all in text.

Known issues with pull request:

Change log entry:

Section: Bug fixes

NVDA no longer activates Say All profile if there is nothing to read.

@michaelDCurran michaelDCurran changed the title Don't actibate Say All profile if there is nothing to read Don't activate Say All profile if there is nothing to read Aug 3, 2020
michaelDCurran
michaelDCurran previously approved these changes Aug 3, 2020
@michaelDCurran michaelDCurran merged commit a8d4ed8 into nvaccess:master Aug 3, 2020
@nvaccessAuto nvaccessAuto added this to the 2020.3 milestone Aug 3, 2020
@lukaszgo1 lukaszgo1 deleted the I10899 branch August 4, 2020 08:33
@Adriani90
Copy link
Collaborator

The lucky effect of this is that it also fixed #4789. NVDA performs now say all in lists as well. I will close that issue as well. Thanks for fixing this.

@Adriani90
Copy link
Collaborator

I tested this in CCleaner in a list ans also in Windows Explorer and NVDA reads all items. However, it seems the say all profile gets triggered on text and other elements such as buttons, but not in lists.

The expected behavior would be that the say all profile gets triggered also in lists when performing say all, like it does when reading text.

@Adriani90
Copy link
Collaborator

Oops, sorry for the noise, it turned out I had the addon column review enabled, that's why say all in lists and other elements worked for me. Sorry, the issue referenced above is not fixed in the NVDA core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Say all profile gets triggered even when there is no text to read Say all on Desktop raises an error
4 participants