Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dialogs resizable #6332

Open
feerrenrut opened this issue Sep 5, 2016 · 6 comments
Open

Make dialogs resizable #6332

feerrenrut opened this issue Sep 5, 2016 · 6 comments
Labels
component/NVDA-GUI

Comments

@feerrenrut
Copy link
Contributor

Some of the dialogs would benefit from being resizable. Dialogs with list controls (single or multi-column) or tree views often have entries that are much bigger than the space allocated to them. This can make them more difficult to read. While ideally all dialogs would have a layout that finds the balance between ease to read and not looking oversized, a fairly simple fallback option is to make the dialogs resizable. A user can just resize the dialog in order to fit the content they are interested in on the screen.

Implementation hint: #6189
@feerrenrut feerrenrut mentioned this issue Sep 5, 2016
Closed
@feerrenrut
Copy link
Contributor Author

Specific request for the elements list: #946

@feerrenrut feerrenrut mentioned this issue Sep 7, 2016
Closed
@LeonarddeR LeonarddeR mentioned this issue Jul 7, 2017
Closed
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI: Make Input Gestures Dialog resizeable (nvaccess#6332)
32e8bbf
@JulienCochuyt JulienCochuyt mentioned this issue Sep 11, 2019
Merged
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI: Allow to maximize settings dialogs that are already resizable (n…
a5c8cbc 
…vaccess#6332)
@JulienCochuyt JulienCochuyt mentioned this issue Sep 11, 2019
Merged
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI: Do not allow Settings Dialogs to shrink below their minimum size (…
cf30e1e 
…nvaccess#6332)
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI: Allow the Input Gestures Dialog to shrink below its initial size (…
8ad6f04 
…nvaccess#6332)
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI: Allow the Speech Symbols dialog to be enlarged vertically (nvacc…
5f1e02a 
…ess#6332)
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI: Do not allow Settings Dialogs to shrink below their minimum size (…
0ab3fa8 
…nvaccess#6332)
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI Helper: Allow labeled List and Tree controls to expand in both di…
caee97f 
…rections (nvaccess#6332)
@JulienCochuyt JulienCochuyt mentioned this issue Sep 11, 2019
Merged
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI: Make Dictionary Dialog resizeable (nvaccess#6332)
8e6d0c7
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI: Do not allow Settings Dialogs to shrink below their minimum size (…
89a7b45 
…nvaccess#6332)
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI Helper: Allow labeled List and Tree controls to expand in both di…
522d12d 
…rections (nvaccess#6332)
@JulienCochuyt JulienCochuyt mentioned this issue Sep 11, 2019
Merged
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI: Make the Addons dialog resizable and maximizable (nvaccess#6332)
e9330c1
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI: Make Incompatible Addons dialog resizable and maximizable (nvacc…
58d87b0 
…ess#6332)
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 11, 2019
@JulienCochuyt
GUI Helper: Allow labeled List and Tree controls to expand in both di…
f25aef7 
…rections (nvaccess#6332)
@JulienCochuyt JulienCochuyt mentioned this issue Sep 11, 2019
Merged
@JulienCochuyt
Copy link
Collaborator

Ok, I think I got caught by my own enthusiasm. I did not have the initial intention to impact the whole of these dialogs.
@feerrenrut, would you prefer I squash PRs #10189, #10190, #10198, #10203 and #10204 into a single PR or is it fine for you to review as is?

@feerrenrut
Copy link
Contributor Author

Yes, separate PR's is fine, probably easier actually. Thanks!

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 13, 2019
@JulienCochuyt
Revert "GUI: Allow the Input Gestures Dialog to shrink below its init…
8cf42a0 
…ial size (nvaccess#6332)"

This reverts commit 8ad6f04.
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 13, 2019
@JulienCochuyt
Fix up of e9330c1: Refine the comment re initial vs minimum size (nva…
c4ce636 
…ccess#6332)
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 13, 2019
@JulienCochuyt
Fix up of 58d87b0: Refine the comment re initial vs minimum size (nva…
ccacc05 
…ccess#6332)
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 13, 2019
@JulienCochuyt
Fix up of 8e6d0c7: Refine the comment re initial vs minimum size (nva…
15b8cf9 
…ccess#6332)
feerrenrut pushed a commit that referenced this issue Sep 13, 2019
@JulienCochuyt @feerrenrut
GUI: Make Input Gestures Dialog resizeable (PR #10189)
866cc7e 
Issue: #6332

Make the input gesture dialog resizable. For resizable dialogs, setting an initial size on one of the controls in the dialog will affect the minimum size.
feerrenrut pushed a commit that referenced this issue Sep 13, 2019
@JulienCochuyt @feerrenrut
GUI: Make the Dictionary dialogs resizeable (PR #10203)
d3161a5 
Make Dictionary Dialog resizable
Issue: #6332
feerrenrut pushed a commit that referenced this issue Sep 13, 2019
@JulienCochuyt @feerrenrut
GUI: Allow the Speech Symbols dialog to be enlarged vertically (PR #1…
c16af59 
…0198)

Allow the Speech Symbols dialog to be enlarged vertically 

Issue: #6332
feerrenrut pushed a commit that referenced this issue Sep 13, 2019
@JulienCochuyt @feerrenrut
GUI: Allow maximizing settings dialogs that are already resizable (PR #…
fb1e9c4 
…10190)

Settings dialogs that use the resizable keyword arg additionally get the maximise button style
Issue: #6332
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 13, 2019
@JulienCochuyt
Fix up of ccacc05: Refine the comment re initial vs minimum size (nva…
f4d4007 
…ccess#6332)
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 13, 2019
@JulienCochuyt
Fix up of c4ce636: Refine the comment re initial vs minimum size (nva…
fede5a9 
…ccess#6332)
feerrenrut pushed a commit that referenced this issue Sep 16, 2019
@JulienCochuyt @feerrenrut
GUI: Make the Addons dialogs resizable and maximizable (PR #10204)
8a7a086 
Issue #6332
@lukaszgo1
Copy link
Contributor

@JulienCochuyt As all your PR's related to this issue are now merged could you provide a status update for this one? What remains to be done?

@JulienCochuyt
Copy link
Collaborator

@lukaszgo1 wrote:

@JulienCochuyt As all your PR's related to this issue are now merged could you provide a status update for this one? What remains to be done?

I still have a few of these in my bucket, but I'd thought it would wait for after #11006, unless GUI layout "fixes" might still be acceptable in the meantime.

Notably, I did not post yet my tweaks on Elements Dialog resizing, Dictionary Entry fields aligning and expansion nor Speech and Braille viewers keyboard resizing and maximization.

@feerrenrut, please let me know if you wish I post some of these or keep holding off.

@feerrenrut
Copy link
Contributor Author

Thanks for your work on this @JulienCochuyt , but please hold off for now. Our goal is to get our list of non-draft unblocked PR's down to just a handful of the newest issues. Unfortunately the older PRs are often no longer maintained, or were never finished, and there are a few that might be questionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/NVDA-GUI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@feerrenrut @lukaszgo1 @JulienCochuyt