Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower log level to debug warning for lock screen not found case #14457

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Dec 18, 2022

Link to issue number:

Closes #14475
Follow up for #14416

Summary of the issue:

#14416 added a log message at exception level.
This log message is for when the relative z-order for an NVDAObject and the lock screen cannot be determined.
While a noisy exception here is useful for alpha/beta testing of this code, this log message is almost always triggered once when locking windows. This is because the lock screen may not exist while windows is in the process of locking.

Description of user facing changes

Lower log level

Description of development approach

n/a

Testing strategy:

n/a

Known issues with pull request:

N/a

Change log entries:

N/a

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner December 18, 2022 23:57
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team December 18, 2022 23:57
@seanbudd seanbudd changed the base branch from beta to master December 19, 2022 01:25
@seanbudd seanbudd changed the base branch from master to beta December 19, 2022 01:25
@seanbudd seanbudd closed this Dec 19, 2022
@seanbudd seanbudd reopened this Dec 19, 2022
@seanbudd seanbudd added this to the 2022.4 milestone Dec 19, 2022
@seanbudd seanbudd marked this pull request as draft December 19, 2022 01:27
@seanbudd seanbudd changed the base branch from beta to master December 27, 2022 23:02
@seanbudd seanbudd modified the milestones: 2022.4, 2023.1 Dec 27, 2022
@seanbudd seanbudd marked this pull request as ready for review December 28, 2022 00:14
@seanbudd
Copy link
Member Author

marking this as blocked until there has been sufficient testing of #14416. Once #14416 has been out for 1-2 months we can consider merging.

@seanbudd seanbudd removed the blocked label Jan 3, 2023
@seanbudd seanbudd merged commit 3c7dd8e into master Jan 4, 2023
@seanbudd seanbudd deleted the lowerLogLevel branch January 4, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NVDA2022.3.3 throws error for a split second when computer goes to sleep
2 participants