Adds babel-preset-env #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delambo
force-pushed
the
adds-babel-preset-env
branch
3 times, most recently
from
d5dd2b5 to
908cd3e
Compare
tweaks adds hot-loader npm version adds kyt eslint fix test
delambo
force-pushed
the
adds-babel-preset-env
branch
from
908cd3e to
6e688af
Compare
tizmagik
approved these changes
Aug 28, 2017
2 tasks
|
As a follow-on PR (or maybe as part of this one) we should also set |
ccpricenytimes
approved these changes
Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
babel-preset-latestwithbabel-preset-envinbabel-preset-kyt-core.Because the lerna hoisting doesn't work for all dependencies, I added some hoisting exceptions to the lerna.json configuration and a script that installs the starter kyt dependencies but keeps the lerna symlinks. That way, starter kyt commands like
kyt devcan work against the local repository. One drawback to the hoisting that I haven't figured out is thatkyt testdoes not work against the starter kyts, but I'm not terribly concerned about that since the starter kyt unit tests are for show.