babel-preset-latest => babel-preset-env #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
coming from #356 I'm not sure how to use this PR if I merge it locally; as the docs mentioned I have created a .babelrc but it seems kyt is not honoring it |
|
Ah, sorry for the confusion. The latest kyt on npm (0.3.0) does not honor a local .babelrc -- that will happen in 0.4.0 (which is what master reflects currently). For now, you'll need to manually override babel settings in modifyWebpackConfig() in kyt.config.js If you're saying you've tried 0.4.0 (master branch) locally and it's not honoring your local .babelrc then that might be a bug... |
* master: (26 commits) Expand version range of yarn for Travis (#400) update migration guide to 0.4.0 (#398) Update CHANGELOG.md adds 040 final version (#392) 0.4.0 docs (#338) adds yarn version check to bootstrap (#391) Making kyt a dependency rather than a devDependency (#387) adds more functional tests (#388) rc5 (#384) fixes stylelintrc glob so that it respects file extensions (#383) prep work for rc3 (#381) Interactive setup (#378) Update webpack.base.js (#365) Adds monorepo bootstrap (#377) fixes linter peer dependencies (#380) Fix typo (#379) kyt-cli version bump (#376) updates the kyt-cli version (#370) fixes cli starter kyt path bug (#369) Adds prep for 0.4.0 release candidate (#368) ...
|
@tizmagik - Would it be safe to merge this as-is and followup with the other tasks? |
|
Yea maybe, let me see what's going on with the tests |
* master: removes transform runtime plugin from jest config (#414)
adds starter kyt beta versions
delambo
force-pushed
the
babel-preset-env
branch
from
07799c0 to
9d81133
Compare
* master: updates starter kyts to kyt 0.5.1 (#452)
# Conflicts: # bootstrap.js # packages/babel-preset-kyt-core/yarn.lock # packages/babel-preset-kyt-react/yarn.lock # packages/kyt-cli/yarn.lock # packages/kyt-core/package.json # packages/kyt-core/yarn.lock # packages/kyt-starter-static/package.json # packages/kyt-starter-static/starter-src/package.json # packages/kyt-starter-static/starter-src/yarn.lock # packages/kyt-starter-universal/package.json # packages/kyt-starter-universal/starter-src/package.json # packages/kyt-starter-universal/starter-src/yarn.lock # yarn.lock
|
Closing in favor of #531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #312
Still todo for this PR:
"node":"current"babel target setting for server build (docs)cc @jaredmcdonald