[ocaml-gen] rename macros and revert multi-declaration of custom types #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 88.91% 88.93% +0.01%
==========================================
Files 74 74
Lines 18248 18207 -41
==========================================
- Hits 16226 16192 -34
+ Misses 2022 2015 -7
Continue to review full report at Codecov.
|
jspada
reviewed
Oct 22, 2021
circuits/plonk-15-wires/src/gate.rs
Outdated
| row: CurrOrNext::Curr, | ||
| column, | ||
| }; | ||
| let chacha_pattern = (0..4) |
There was a problem hiding this comment.
This diff looks very similar to the one from PR193
There was a problem hiding this comment.
this is because of reformating issues :/ which will be fixed in one of the PR: #193
mimoo
force-pushed
the
mimoo/ocaml_custom2
branch
4 times, most recently
from
2875e51
to
234692b
Compare
|
rebased |
mimoo
force-pushed
the
mimoo/ocaml_custom2
branch
from
586be3c
to
f32e5c2
Compare
|
rebased |
mimoo
force-pushed
the
mimoo/ocaml_custom2
branch
from
f32e5c2
to
40b8f05
Compare
mrmr1993
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #172 (comment)
tl;dr is that this is that declaring the same custom type multiple times is error-prone. I'm investigating another solution.
as for name changes: