[kimchi] fix bugs and abstraction for permutation's shifts #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimoo
force-pushed
the
mimoo/permut
branch
2 times, most recently
from
69b6a4c
to
ed27473
Compare
jspada
reviewed
Oct 22, 2021
mimoo
force-pushed
the
mimoo/permut
branch
2 times, most recently
from
99bc99d
to
145ed61
Compare
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 88.52% 88.67% +0.14%
==========================================
Files 73 73
Lines 17536 17593 +57
==========================================
+ Hits 15524 15600 +76
+ Misses 2012 1993 -19
Continue to review full report at Codecov.
|
jspada
reviewed
Oct 28, 2021
| &'a self, | ||
| domain: EvaluationDomains<F>, | ||
| gates: &Vec<CircuitGate<F>>, | ||
| ) -> Vec<E<F, D<F>>> { | ||
| let n = domain.d1.size as usize; |
There was a problem hiding this comment.
would be better rename n to domain1_size
There was a problem hiding this comment.
agree, I renamed it in the prover code to d1_size, I'd approve it if you do a PR to rename one-letter variables :o
jspada
approved these changes
Oct 28, 2021
… COLUMNS As we only care about the wiring of the first 7 (PERMUTS) columns, not all 15 (COLUMNS) columns.
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things:
cargo fmtin CI (and format the unformatted files)(Happy to split this up in several PRs if this is a pain to review.)
It uses
std::array::IntoIterbut tomorrow, with the release Rust 2021, we'll be able to useinto_iter()directly on arrays (see rust-lang/rust#65819 (comment) and https://blog.rust-lang.org/2021/05/11/edition-2021.html#intoiterator-for-arrays)I can fix that once #198 is merged