[kimchi][proof] add zero-knowledge rows in witness #197
Conversation
| @@ -5,7 +5,7 @@ This source file implements Plonk circuit constraint primitive. | |||
| *****************************************************************************************************************/ | |||
There was a problem hiding this comment.
if #193 goes first, it'll be easier to review this PR as the formatting changes will be gone
|
maybe before I start fixing all the tests, some feedback from @imeckler @mrmr1993 on the approach? Because I want to make sure that we're not overwriting rows, when randomizing the last 3 rows, I expect the witness to be passed non-padded. This change means that we have to manually pad the witness when we're creating proofs, or double-checking the witness. |
mimoo
force-pushed
the
mimoo/rand
branch
2 times, most recently
from
8ac3715
to
b0fc55e
Compare
|
|
||
| // double-check the witness | ||
| if cfg!(test) { | ||
| index.cs.verify(&witness).expect("incorrect witness"); |
There was a problem hiding this comment.
Does cfg! work in such a way that in production builds this won't run? How is it controlled?
There was a problem hiding this comment.
yeah that should be replaced to false in production/debug build, and replaced to true when running test. I can remove it if it looks scary though :o
mimoo
force-pushed
the
mimoo/rand
branch
4 times, most recently
from
cb7c49c
to
eb2de0c
Compare
|
rebased, fixing remaining tests now |
mimoo
force-pushed
the
mimoo/rand
branch
2 times, most recently
from
2fe31d6
to
7ade0ca
Compare
|
just so that there are no surprised, added an error in ProofError |
this was previously done on the OCaml side. This is better because the caller doesn't have to think about doing it. To make sure that the caller didn't mess up this part, we now ask the caller to send the unpadded witness columns.
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
- Coverage 88.90% 88.90% -0.01%
==========================================
Files 74 74
Lines 18212 18248 +36
==========================================
+ Hits 16192 16223 +31
- Misses 2020 2025 +5
Continue to review full report at Codecov.
|
We currently add zero-knowledge rows to the witness on the OCaml side. This is not great as this library might be used by all sorts of people who might not think about adding the zero-knowledge stuff.