Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulleted lists in tables #252

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Bulleted lists in tables #252

merged 10 commits into from
Apr 11, 2024

Conversation

HeikoTheissen
Copy link
Contributor

No description provided.

@ralfhandl
Copy link
Contributor

Actually I thought we could to this automatically in function

function escape(text) {
return (text || "")
.trim()
.replace(/\n\n/g, "<br/>")
.replace(/\n/g, " ")
.replace(/[ \t]+/g, " ")
.replace(/\|/g, "\\|");
}

@ralfhandl
Copy link
Contributor

ralfhandl commented Apr 11, 2024

let's ask the author to do it once

So the author has to know which LongDescription we render into a paragraph and which into a table cell 🤔?

Maybe the problem actually is using tables instead of sub(sub)sections.

Let's discuss this in the TC, I've added the PR to the Review column

@HeikoTheissen
Copy link
Contributor Author

Actually I thought we could to this automatically in function

function escape(text) {
return (text || "")
.trim()
.replace(/\n\n/g, "<br/>")
.replace(/\n/g, " ")
.replace(/[ \t]+/g, " ")
.replace(/\|/g, "\\|");
}

Pandoc on the fly works!

@HeikoTheissen
Copy link
Contributor Author

Maybe the problem actually is using tables instead of sub(sub)sections.

Let's discuss this in the TC, I've added the PR to the Review column

With the pandoc-on-the-fly solution, I think we can stick to tables.

@ralfhandl
Copy link
Contributor

Feel free to merge as this PR does not change the vocabulary text

@HeikoTheissen HeikoTheissen merged commit 9596c6a into main Apr 11, 2024
1 check passed
@HeikoTheissen HeikoTheissen deleted the typographics branch April 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants