Fix/aut 3923/textreader image figure support #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olga-kulish
changed the base branch from
develop
to
fix/AUT-3876/editor-passage-remove
This was referenced Nov 8, 2024
oatymart
reviewed
Nov 11, 2024
views/js/pciCreator/ims/textReaderInteraction/creator/scss/textReaderInteraction.scss
Outdated
Show resolved
Hide resolved
Base automatically changed from
fix/AUT-3876/editor-passage-remove
to
develop
November 13, 2024 10:00
wazelin
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
wazelin
added a commit
to oat-sa/tao-community
that referenced
this pull request
Nov 21, 2024
…eases/tag/v54.20.1.1)** - _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#4125](oat-sa/tao-core#4125) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) **[oat-sa/extension-tao-itemqti v30.20.0.2](https://github.com/oat-sa/extension-tao-itemqti/releases/tag/v30.20.0.2)** - _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#2613](oat-sa/extension-tao-itemqti#2613) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) ) - _Fix_ [AUT-3876](https://oat-sa.atlassian.net/browse/AUT-3876) : editor passage remove [#2605](oat-sa/extension-tao-itemqti#2605) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) ) **[oat-sa/extension-pcisample v3.9.2](https://github.com/oat-sa/extension-pcisample/releases/tag/v3.9.2)** - _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#172](oat-sa/extension-pcisample#172) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) ) **[oat-sa/extension-pcisample v3.9.1](https://github.com/oat-sa/extension-pcisample/releases/tag/v3.9.1)** - _Fix_ [AUT-3876](https://oat-sa.atlassian.net/browse/AUT-3876) : editor passage remove [#171](oat-sa/extension-pcisample#171) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://oat-sa.atlassian.net/browse/AUT-3923
Changes
textReaderInteraction.scssPosition "remove" icon for Figure. Same style is used in
taoQtiItem-->item-creator.cssfor inline widgets.Question.jsSet
data-element-support-figure- this is needed for Fix/aut 3923/textreader image figure support extension-tao-itemqti#2613 where we check if<figure>is supported (if it's not supported,wrap-left/wrap-rightwill be applied directly to<img>).In pratice the difference is whether
figcaptionis available or not. So we could remove this data attribute for simplicity, and just disable<figure>for all PCIs.renderer.jsSince usual renderers of QTI elements don't run in PCI, we need to copy this functionality inside PCI. Maybe this should be moved to portableLib. Need to remove
qh5:namespace too.Notes
When I click on Figure in CkEditor, there's an error:
I have no idea how to fix it yet. Looks harmless, so let's ignore it?
To get rid of it, we can sacrifice
figcaptionand disable<figure>support (and apply wrap class directly on<img>).To test
On unit05. Related PRs: