Fix/aut 3876/editor passage remove #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
oatymart
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
I didn't look into the other ways this could be solved, but these changes seem to fix it and are small enough. LGTM.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master(ormain) - or is a release - Bundled code is present if needed
-
Version bump is applied if needed (packages AND root) - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
-
Changelog is updated according to changes (if applicable) - Documentation is updated according to changes (if applicable)
added 2 commits
November 14, 2024 12:15
…mqti into fix/AUT-3876/editor-passage-remove
Version
There are 0 BREAKING CHANGE, 0 feature, 2 fixes |
wazelin
added a commit
to oat-sa/tao-community
that referenced
this pull request
Nov 21, 2024
…eases/tag/v54.20.1.1)** - _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#4125](oat-sa/tao-core#4125) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) **[oat-sa/extension-tao-itemqti v30.20.0.2](https://github.com/oat-sa/extension-tao-itemqti/releases/tag/v30.20.0.2)** - _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#2613](oat-sa/extension-tao-itemqti#2613) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) ) - _Fix_ [AUT-3876](https://oat-sa.atlassian.net/browse/AUT-3876) : editor passage remove [#2605](oat-sa/extension-tao-itemqti#2605) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) ) **[oat-sa/extension-pcisample v3.9.2](https://github.com/oat-sa/extension-pcisample/releases/tag/v3.9.2)** - _Fix_ [AUT-3923](https://oat-sa.atlassian.net/browse/AUT-3923) : textreader image figure support [#172](oat-sa/extension-pcisample#172) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) ) **[oat-sa/extension-pcisample v3.9.1](https://github.com/oat-sa/extension-pcisample/releases/tag/v3.9.1)** - _Fix_ [AUT-3876](https://oat-sa.atlassian.net/browse/AUT-3876) : editor passage remove [#171](oat-sa/extension-pcisample#171) ( by [olga-kulish](https://github.com/olga-kulish) - validated by [olga-kulish](https://github.com/olga-kulish) )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://oat-sa.atlassian.net/browse/AUT-3876
Deployed to unit01
Caused by fix: pass contentEditable flag value to newly rebuild widget object f… #2517 . For TextReaderInteraction PCI issue, proper solution should be to set
shieldInnerContent : truehttps://github.com/oat-sa/extension-tao-itemqti/blob/master/views/js/qtiCreator/editor/containerEditor.js#L249 . Or we could at least add an transparent-gray-overlay similar.html-editable-shieldfor.edit-sleepstate of Passage. That's easy, but I'm not 100% sure it's a good thing. It will look less like "Preview". Maybe it was on purpose that it wasn't enabled?..Also, fix for styles of remove button: Fix/aut 3876/editor passage remove extension-pcisample#171