Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties without range will throw exception #2587

Conversation

bartlomiejmarszal
Copy link
Contributor

In order to defenese ChecksumGenerator service from passing property without range

Copy link

github-actions bot commented Oct 14, 2024

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
287 287 0 0

@bartlomiejmarszal bartlomiejmarszal mentioned this pull request Oct 14, 2024
1 task
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Just a suggestion for log message

Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link

Version

Target Version 30.21.7
Last version 30.21.6

There are 0 BREAKING CHANGE, 0 feature, 4 fixes

@bartlomiejmarszal bartlomiejmarszal merged commit 0ef2ab5 into develop Oct 21, 2024
5 checks passed
@bartlomiejmarszal bartlomiejmarszal deleted the fix/AUT-3916/throw-error-for-properties-without-range branch October 21, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants