Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/BSA-391/2.3.0/Allow to disable figure widgets #580

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Feature/BSA-391/2.3.0/Allow to disable figure widgets #580

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
632b217
feat: do not manage the figure widget if the feature flag FEATURE_FLA…
jsconan Dec 7, 2023
e4b27a6
chore: bump version
jsconan Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/mediaEditor/plugins/mediaAlignment/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* Copyright (c) 2021-2022 (original work) Open Assessment Technologies SA;
* Copyright (c) 2021-2023 (original work) Open Assessment Technologies SA;
*/
import context from 'context';
import _ from 'lodash';

export const FLOAT_LEFT_CLASS = 'wrap-left';
Expand Down Expand Up @@ -74,7 +75,7 @@ export const positionFloat = function positionFloat(widget, position) {
widget.element.removeAttr('class');
}

if (prevClassName !== className) {
if (!context.featureFlags['FEATURE_FLAG_DISABLE_FIGURE_WIDGET'] && prevClassName !== className) {
// Re-build Figure widget to toggle between inline/block
const parent = searchRecurse(widget.element.bdy.rootElement.bdy, widget.serial);
// avoid changes on Figure in a prompt
Expand Down