Feature/BSA-391/2.3.0/Allow to disable figure widgets #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…G_DISABLE_FIGURE_WIDGET is set
This was referenced Dec 7, 2023
This was referenced Dec 8, 2023
gabrielfs7
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Thanks @jsconan ,
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable) - JS did a demo
- Acceptance criteria are respected
- Pull request title and description are meaningful
erkobridee
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
looks good 👍
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
jsconan
deleted the
feature/BSA-391/2.3.0/allow-to-disable-figure-widgets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/BSA-391
Summary
Manage a feature flag for disabling the figure widget.
Details
Note: This PR targets version
2.3.0since version3.xcontains breaking changes and is not yet used bytao-core.Some customers rely on the block positioning of the figures for aligning images in columns. The figure widget sets them to inline positioning, hence the need to have a feature flag for disabling it. The other possibility is to roll back the feature, but this is less handy.
The feature can be disabled thanks to the feature flag
FEATURE_FLAG_DISABLE_FIGURE_WIDGET.The feature is enabled by default.
How to test