Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/BSA-391/Allow to disable figure widgets #3935

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Dec 7, 2023

Related to: https://oat-sa.atlassian.net/browse/BSA-391

Requires:

Summary

Manage a feature flag for disabling the figure widget.

Details

Some customers rely on the block positioning of the figures for aligning images in columns. The figure widget sets them to inline positioning, hence the need to have a feature flag for disabling it. The other possibility is to roll back the feature, but this is less handy.

The feature can be disabled thanks to the feature flag FEATURE_FLAG_DISABLE_FIGURE_WIDGET.
The feature is enabled by default

How to test

  • have all dependencies (other PR) installed
  • edit an item and place images on the canvas. Check the attached ticket for a sample item.
  • turn the feature flag on and off, and see the differences

Tidbit

To set and manage the feature flag, take a look at this documentation.

php index.php 'oat\tao\scripts\tools\FeatureFlag\FeatureFlagTool' -s FEATURE_FLAG_DISABLE_FIGURE_WIDGET -v true

Copy link

github-actions bot commented Dec 7, 2023

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
161 161 0 0

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e6db47) 27.35% compared to head (fa1d83e) 27.26%.
Report is 17 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3935      +/-   ##
=============================================
- Coverage      27.35%   27.26%   -0.10%     
- Complexity     10971    11006      +35     
=============================================
  Files            922      926       +4     
  Lines          33810    33928     +118     
=============================================
  Hits            9250     9250              
- Misses         24560    24678     +118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

@erkobridee erkobridee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

Copy link

Version

Target Version 53.14.3
Last version 53.14.2

There are 0 BREAKING CHANGE, 0 feature, 0 fix

@jsconan jsconan merged commit 737f428 into develop Dec 11, 2023
6 of 7 checks passed
@jsconan jsconan deleted the feature/BSA-391/allow-to-disable-figure-widgets branch December 11, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants