-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/BSA-391/Allow to disable figure widgets #3935
Feature/BSA-391/Allow to disable figure widgets #3935
Conversation
…sable-figure-widgets
Front-end summary Node 18
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3935 +/- ##
=============================================
- Coverage 27.35% 27.26% -0.10%
- Complexity 10971 11006 +35
=============================================
Files 922 926 +4
Lines 33810 33928 +118
=============================================
Hits 9250 9250
- Misses 24560 24678 +118 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
- Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
Version
There are 0 BREAKING CHANGE, 0 feature, 0 fix |
Related to: https://oat-sa.atlassian.net/browse/BSA-391
Requires:
Summary
Manage a feature flag for disabling the figure widget.
Details
Some customers rely on the block positioning of the figures for aligning images in columns. The figure widget sets them to inline positioning, hence the need to have a feature flag for disabling it. The other possibility is to roll back the feature, but this is less handy.
The feature can be disabled thanks to the feature flag
FEATURE_FLAG_DISABLE_FIGURE_WIDGET
.The feature is enabled by default
How to test
Tidbit
To set and manage the feature flag, take a look at this documentation.