feat(collection): enable cloudwatch logs discovery #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
force-pushed
the
joao/discovery-collection
branch
from
4926c00
to
feef232
Compare
jta
force-pushed
the
joao/discovery-collection
branch
from
feef232
to
6d92035
Compare
obs-gh-colinhutchinson
approved these changes
Dec 14, 2023
Configure daily discovery event. This can be hardcoded to reduce configuration fatigue. As a result of this change, we can no longer explicitly configure subscription filters, since there is a possibility of race condition between "discovery" and the explicit filter. If a user wants to forward the log groups created by the stack, they would have to provide the stack name as one of the LogGroupPatterns.
jta
force-pushed
the
joao/discovery-collection
branch
from
6d92035
to
bd86078
Compare
|
🎉 This PR is included in version 1.5.0-beta.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure daily discovery event. This can be hardcoded to reduce configuration fatigue.