feat(collection): export log groups #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jta
force-pushed
the
joao/loggroupnameexport
branch
4 times, most recently
from
108bbbf
to
7d7acb1
Compare
Our logic was busted. It was passing tests because the test fixture had a lambda ARN instead. Provide fix and add a new test for the happy path of a firehose ARN alongside the role ARN.
jta
force-pushed
the
joao/loggroupnameexport
branch
from
6dd6e60
to
d64f142
Compare
Add static subscriptions for the log groups we do create. This should not clash with the subscriber module since the filter name is set to match (`observe-logs-subscription`).
jta
force-pushed
the
joao/loggroupnameexport
branch
from
d64f142
to
8229c41
Compare
|
🎉 This PR is included in version 1.4.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add static subscriptions for the log groups we do create. This should not clash with the subscriber module since the filter name is set to match (
observe-logs-subscription).