Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collection): export log groups #104

Merged
merged 2 commits into from
Nov 29, 2023
Merged

feat(collection): export log groups #104

merged 2 commits into from
Nov 29, 2023

Commits on Nov 29, 2023

  1. fix(subscriber): correct ARN validation for IAM role 

    Our logic was busted. It was passing tests because the test fixture had
a lambda ARN instead. Provide fix and add a new test for the happy path
of a firehose ARN alongside the role ARN.
    @jta
    jta committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    78ca63c View commit details
    Browse the repository at this point in the history

  2. feat(collection): export log groups 

    Add static subscriptions for the log groups we do create. This should
not clash with the subscriber module since the filter name is set to
match (`observe-logs-subscription`).
    @jta
    jta committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    8229c41 View commit details
    Browse the repository at this point in the history