Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow configurable forwarder log prefix #7

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix: allow configurable forwarder log prefix #7

merged 1 commit into from
Oct 6, 2023

Conversation

jta
Copy link
Contributor

@jta jta commented Oct 5, 2023

The forwarder writes all SQS messages processed to a file in the destination S3 bucket. Make the S3 prefix we use configurable (default is forwarder/).

I also took the opportunity to use more precise language: SQS handles messages, not events. As a result, we are logging messages, rather than "recording results". I also fixed a few lint issues raised by golangci-lint which had slipped when committing straight to master.

The forwarder writes all SQS messages processed to a file in the
destination S3 bucket. Make the S3 prefix we use configurable (default
is `forwarder/`).

I also took the opportunity to use more precise language: SQS handles
messages, not events. As a result, we are logging messages, rather than
"recording results". I also fixed a few lint issues raised by
golangci-lint which had slipped when committing straight to master.
@jta jta merged commit 822822c into main Oct 6, 2023
2 checks passed
@jta jta deleted the joao/prefix branch October 6, 2023 15:00
obs-gh-colinhutchinson added a commit that referenced this pull request Oct 12, 2023
* feat: use relative stack location

SAM will handle uploading the stacks to an S3 bucket for us, which seems
more appropriate than trying to figure out how to dynamically load
the appropriate application Id.

* fix: ignore the W3002 lint rule

* chore: ran the Makefile through a linter

* feat: ability to release to multiple regions

* wip

* feat: setup automation for github releases

* feat: empty commit to force a release

* fix: fix the release logic so commits to main are pre-release

* fix: run the release workflow on tags as well

* feat: allow for workflow dispatch to enable proper releases

* fix: try debuggin why the config option doesn't work

* fix: debug if the issue is the .releaserc

* fix: provide absolute path to the releaserc

* fix: continue debugging

* feat: needs the file extension to keep node happy

* feat: empty commit to force a release

* feat: empty commit to force a release

* feat: terraform to setup the aws / github federation

* chore: check the terraform worked

* feat: connect github releases with AWS SAM releases

* feat: connect github releases with AWS SAM releases

* chore: revert to see if we can release now

* feat: connect aws sam releases w\ github releases

* feat: when releasing do a build before doing the github release in case something is broken

* feat: make all SAM commands region sensitive

* docs: ammend the release workflow to the README.md

* chore(release): add get-caller-identity to the release workflow

* fix: set the release version for prerelease and full releases

* fix: releases need to include the packaged.yaml cloudformation file

* chore: introduce dependabot

* fix: syntax error with sending arguments to the forwarder aws sam stack (#11)

* chore(deps): bump github.com/google/go-cmp from 0.5.8 to 0.6.0 (#10)

* chore(deps): bump github.com/aws/aws-sdk-go-v2 from 1.21.0 to 1.21.1 (#9)

* chore(deps): bump actions/setup-go from 2 to 4 (#5)

* chore(deps): bump actions/checkout from 2 to 4 (#4)

* chore(deps): bump github.com/aws/aws-sdk-go-v2/config (#7)

* chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (#6)

* fix: don't run releases on dependabot commits

* feat: force a release

* feat: add beta/latest convenience releases

* fix: stable pointer only for workflow dispatch

* remove references to colin

---------

Co-authored-by: João Taveira Araújo <joao@observeinc.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants