-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native arm64 build slice to all Windows dependencies #190
base: master
Are you sure you want to change the base?
Conversation
4fe3845
to
3f37412
Compare
3f37412
to
0ff2fee
Compare
0ff2fee
to
e18f0e7
Compare
What is the error exactly in building mbedtls? I saw upstream fixed similar issues multiple times. |
e18f0e7
to
1587850
Compare
Compiling
This is possibly fixed by Mbed-TLS/mbedtls#8168, so we're waiting for MbedTLS to cut a new release with those fixes included. |
6f09be1
to
58c4660
Compare
This needs to be rebased and merge #227 in. |
@PatTheMav and I work closely together off-thread. Rest assured, that we discuss this regularly. However, do note that this is being worked on as time and other priorities allow. Thank you for your understanding. |
May I join the conversation? |
I appreciate the enthusiasm, but these are conversations that we have either on voice calls or in ongoing DMs about getting stuff to work. It is mostly stuff like "so about that PR" and "here's an idea" and "here's how we might get that to work when we have time". The point is that he doesn't need a reminder to rebase this. He's aware. This is on our roadmap to address. |
How about we start a separate thread in the development channel? Or I could just ask and @ both of you in the channel? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some quick observations. I did get a local Qt build working, but it requires setting both QT_QMAKE_TARGET_MKSPEC
and QT_HOST_PATH
. I've commented how I might approach this for CI. We can attempt to optimize it later.
Was just skimming back over this.
This seems like it should be a trivial Merge Request on the x264 repo. Ideally, I'd like the change to happen there at some point.
VideoLAN's dav1d is a decoder only. It is not an encoder. Xiph's rav1e is an encoder. |
3f2d466
to
bc8100a
Compare
This is specific to Game Capture, right? I guess for now we could just let this slide for now, since the last known good ARM64 build works perfectly fine on Desktop capture, and that would cover at least 90% of the use cases. Snapdragon X Elite/Plus isn't intended to be a video game platform, so this could be put at the bottom of the list. |
Game Capture and Virtual Camera both require both 64-bit and 32-bit components on x64 Windows. The minute we ship a build without features we'll be asked why it doesn't include X, Y, and Z repeatedly. Given that historically, we have only had to contend with x86 (32-bit) and x64 (64-bit) on Windows, there are components that include 32 or 64 or the like in their name, so the build specifications for these (in CMake) and code that interfaces with those filenames must be made aware that a non-32-bit, non-64-bit type/name is possible (arm). Rest assured, we have considered these points when thinking about our path forward. |
Well, we could release a alpha version that lacks that feature, put a huge dialog with huge font, that is non-dismissible for 30 seconds, saying that by continue using you agree to acknowledge that feature X, Y, and Z are missing as they are being worked on, and please don't ask about these features anywhere. The problem I see was Qualcomm used OBS Studio to promote their Snapdragon X Elite platform, while we have no support for Windows on ARM at all, and absolutely no contribution from Qualcomm themselves. |
Thanks for the suggestion, but we already have our own plans for the path forward.
We're aware. |
This is getting noisy, and I would really like to keep comments here to reviewing the code changes rather than policy, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits.
Drop the Sparkle commit. Sparkle is already updated in this repo.
Would still like to see these additional patches submitted to the dependency repos to see if they'll adopt them.
Qualcomm is working on ARM native porting. Very soon we shall be more active here. |
Qualcomm has not reached out to us in any capacity at this time. We hope that they would contact us if they are starting work on the project to port it to a new platform to ensure that efforts are aligned. |
I got the new Surface X, if somebody is needed for Tests so feel free to link me a Build 🙂👍🏻 |
I'm happy to test also if help needed on that. Keen to get a ARM64 windows version of the OBS. |
Any test builds would likely be provided on PRs on the obs-studio repo. In the meantime, I would like to keep comments focused on review or feedback from people who have actually tried to build/test these changes. Thank you for understanding. |
Just a minor correction, Windows 11 ARM edition does not support ARM32 executables on the new Snapdragon Elite processors, and there's no emulation layer for it either, they simply won't work. It's the reason Android subsystem for Windows broke on the Elite processors, it relied on ARM32 binaries. More info here: https://learn.microsoft.com/en-us/windows/arm/arm32-to-arm64 |
210ffa9
to
8a8746b
Compare
I don't think we can update to libsrt 1.5.3 or we'll run into the issues linked in #240. Restating that, if possible, I'd like to see the patches for SRT and libpng upstreamed to their respective repos. I'm mostly only concerned that the patches get submitted. I have been unable to register an account on the VideoLAN GitLab instance to open an Issue about their outdated gas-preprocessor. |
As discussed off-thread with @PatTheMav , updating libsrt to 1.5.3 has known issues in OBS Studio on Windows. These are supposedly resolved in libsrt 1.5.4, which is not yet out/stable. It's not clear to me that libsrt 1.5.3+ is required for WoA/arm64. Can we confirm? Separately, MbedTLS 3.6.0+ is required for WoA/arm64, as far as I know. However, we cannot update that until Haivision/srt#2957 is fixed. This seems to have been addressed by If we need libsrt 1.5.3+, either we wait for all dependencies to be stable, or we teach the Windows dependency build scripts to build different versions per target architecture. Additionally, I still cannot build obs-studio on Windows against libsrt 1.5.3+ and mbedTLS 3.6.0+ due to the bcrypt linking issue, even with the patch here. I haven't tried obsproject/obs-studio#11056 because it fails on CI, and needs to be rebased (I'm guessing gersemi changes). |
f224dee
to
98eb7ab
Compare
98eb7ab
to
012a5fc
Compare
Description
This is an exploratory PR for possible future native ARM64 builds on Windows.
Some dependencies cannot be built for ARM64 yet, others require specific workarounds, yet others can be built for ARM64 but themselves are too recent to be supported by OBS Studio.
This PR will stay in draft state until these and other issues are solved and are in a state that do not result in unnecessary support burden to current maintainers and supporters.
This PR is based on #186 and the PRs it depends on.
Motivation and Context
Due to Visual Studio 17 2022 having full support for ARM64 builds as well as
clang
- andNinja
-based builds, selecting the correct build architecture for MSVC builds does most of the work to achieve native builds, there are some caveats though:libvpx
requires disabling more advanced NEON features not made available by Microsoft's ARM64 implementation.x264
requires an update of thegas-preprocessor
it ships with - luckilyFFmpeg
provides a very recent version of it (the version shipped withx264
is 9 years old)FFmpeg
requires the samegas-processor
to be made available in thePATH
svt-av1
has not been made available as it's not well optimised for ARM64 -dav1d
would be a better alternative, butaom
is "good enough" for nowQt6
builds without any additional hacks or issuesLuaJIT
has merged ARM64 and is available nowPython
supports Windows ARM64 since version 3.11, alas OBS Studio does not support Python 3.11 at runtime yet (you could build OBS Studio with it, but people couldn't add its libraries at runtime)mbedtls
is still broken on ARM64 with version 3.5.1libdatachannel
requires at leastmbedtls
3.4.0, so both are entirely broken on ARM64 right nowvpl
is disabled for ARM64Aja NTV2
is disabled for ARM64How Has This Been Tested?
Tested on Windows 11 ARM64.
Types of changes
Checklist: