Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps.windows: Remove Carla #227

Merged
merged 2 commits into from
Jan 24, 2024
Merged

deps.windows: Remove Carla #227

merged 2 commits into from
Jan 24, 2024

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Jan 11, 2024

Description

After fairly lengthy and difficult internal discussions, we have decided that using Carla as a host for VST3 (and other) plugins is not the right path forward for the project.

Let's remove this from our deps builds.

Motivation and Context

See:
obsproject/obs-studio#8919 (comment)

We've never shipped a feature in OBS that relies on this, so this isn't a breaking change.

How Has This Been Tested?

Hasn't been tested, but this removal is fairly straightforward. CI will show if this works.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX requested a review from PatTheMav January 11, 2024 19:50
@RytoEX RytoEX self-assigned this Jan 11, 2024
@PatTheMav
Copy link
Member

It's not removed for macOS, is that on purpose?

@RytoEX
Copy link
Member Author

RytoEX commented Jan 11, 2024

It's not removed for macOS, is that on purpose?

No, that's a mistake. Will fix.

@RytoEX
Copy link
Member Author

RytoEX commented Jan 12, 2024

It's not removed for macOS, is that on purpose?

Fixed.

@RytoEX
Copy link
Member Author

RytoEX commented Jan 12, 2024

Will merge this at some point.

After fairly lengthy and difficult internal discussions, we have decided
that using Carla as a host for VST3 (and other) plugins is not the right
path forward for the project.

Let's remove this from our deps builds.
After fairly lengthy and difficult internal discussions, we have decided
that using Carla as a host for VST3 (and other) plugins is not the right
path forward for the project.

Let's remove this from our deps builds.
@RytoEX RytoEX merged commit 6e115f8 into obsproject:master Jan 24, 2024
21 checks passed
@RytoEX RytoEX deleted the remove-carla branch January 24, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants