V3 #933
Merged
V3 #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Less exceptions -- remove internal uses of `BatReturn`
Implementing BatVect.find_opt makes this more efficient (we have at most one allocation for the result, instead of using exception handlers for each left subtree), but the function is not exposed publicly.
…ns-batvect Less exceptions in `batVect`
To reproduce a failure that may depend on the seed 1234, you may use
make test QTEST_SEED=1345
[minor] Makefile: introduce a QTEST_SEED variable to set qtest random seed
Fix some issues in the README
Unfortunately this does break backwards compatibility with qcheck 0.5, so there is now an explicit opam dependency on qcheck >= 0.6. Fixes ocaml-batteries-team#756.
…ompat Fix compilation with OCaml 4.05.0
…ompat Update for compatibility with qcheck 0.6
Additional tests for battext
…ring batNum: handle negatives in of_float_string
Set.Infix used to have operators `<.` and `>.` (for strict subset and strict superset), but `>.` is also used as a code block end-quote by BER. It's been decided to jettison the whole BatSet.Infix module, as a simple and future proof fix. Ref ocaml-batteries-team#908
Also added `Filename.split_extension` Closes ocaml-batteries-team#445
…m#912) Redefining the modules (instead of using those predefined in BatSet) was causing the printers for BatSet.Int and friends useless. Closes ocaml-batteries-team#750
As it is undocumented, unsupported and unsafe. Closes ocaml-batteries-team#848
…es-team#917) Now, BatSeq.Exceptionless.combine returns the longest sequence possible (stopping when one of the input sequence ends). Closes ocaml-batteries-team#418
…caml-batteries-team#918) BatString.split_on_char behavior matches the one of Legacy.String.split_on_char, and that nsplit behavior matches the one of split_on_char. Closes ocaml-batteries-team#845 Closes ocaml-batteries-team#846
Now, users can pattern match Result.t returned from some library using Legacy.Result.Error while Batteries is opened. Ref ocaml-batteries-team#839
List.sum and List.fsum default to 0 (or 0.0) in case the list is empty. Previously, this was raising Invalid_argument. Closes ocaml-batteries-team#519
* high level file locking file interface * with_file_lock: now call user function with the opened file
* Fix batFilename for various old OCaml versions split_extension was relying on remove_extension and extension functions that were introduced in OCaml 4.04.0. Also, an ocaml.deprecated annotation needed to be protected by some preprocessing. Tested with most of supported compiler versions. * Prepare Changelog and NEXT_RELEASE placeholder for v2.11.0 * Update setup.ml based on _oasis Closes ocaml-batteries-team#928
…team#930) * make Unix.sleepf available across all OCaml versions
to reflect more the one from opam-repository
|
I don't know why this patch look so big here. It must be diffing with master despite what the header says. If you diff ocaml-batteries-team's v3 with mine you should ses that there is only one patch touching 4 files (a big merge has been performed not so long ago already). |
|
Can we complete this move before more commits are added to master, requiring a new rebase? |
|
I am ok to merge it. |
|
related to #936 |
|
Please proceed with the renaming of branches, etc. |
|
Done. Welcome in batteries v3! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with latest master.
Please check that it is OK, and then let's make this master.
Notice that I've already pushed a v2 at v2.11.0
Closes #932