Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions added in OCaml 4.10 #936

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

kit-ty-kate
Copy link
Contributor

Fixes #935.

This can be viewed as a first step, some of the functions can be reproduced in batteries to avoid them being available only with OCaml 4.10

@UnixJunkie
Copy link
Member

Hi Kate, Cc: @rixed,
No hard feelings if we ask you to resend this PR against master
once V3 is the new master?
Because, accepting this PR will force us to do yet another minor release.
While, we already anounced the latest minor release was the last.
The next release will be a major one.
Thanks,
F.

@UnixJunkie UnixJunkie mentioned this pull request Jan 6, 2020
Merged
@UnixJunkie
Copy link
Member

@kit-ty-kate no comment?
Regards,
F.

@kit-ty-kate
Copy link
Contributor Author

I don't mind at all (sorry for not responding)

@kit-ty-kate
Copy link
Contributor Author

Would it be ok to merge this PR now and do a release soon? The release for 4.10.0 is planned for Monday afaik (delays may apply)

@UnixJunkie
Copy link
Member

I can merge right now.
For the "new release soon", I am not sure since it is a major release.

@UnixJunkie UnixJunkie merged commit 259a5c9 into ocaml-batteries-team:master Feb 13, 2020
@UnixJunkie
Copy link
Member

Maybe @rixed might be interested in doing the next release.

@kit-ty-kate
Copy link
Contributor Author

For the record I can take care of submitting the release to opam-repository once a tag is available, if you prefer.

@rixed
Copy link
Contributor

rixed commented Feb 15, 2020

I have no interest in packaging, it's just toil that I do only when I need it. I'm generally happy when others do it, but I would also agree to do it regularly so this does not always fall onto the same persons.
That said, I could find time early next week to do a release.

@rixed
Copy link
Contributor

rixed commented Feb 17, 2020

Here is an error that's detected by make test when compiler is 4.10.0+rc2:

File "src/batteries_compattest.ml", line 38, characters 17-21:
38 |   module List = (List: module type of Legacy.List)
                      ^^^^
Error: Signature mismatch:
       ...
       Values do not match:
         val find_map : ('a -> 'b option) -> 'a list -> 'b
       is not included in
         val find_map : ('a -> 'b option) -> 'a list -> 'b option
       File "list.mli", line 240, characters 0-55: Expected declaration
       File "src/batList.mliv", line 461, characters 0-49: Actual declaration

@kit-ty-kate
Copy link
Contributor Author

arf right, sorry. I have a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OCaml 4.10
3 participants