Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-compilation: handle transitive ppx_runtime_libraries #7897

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

x-compilation: handle transitive ppx_runtime_libraries #7897

wants to merge 1 commit into from

Conversation

anmonteiro
Copy link
Collaborator

@anmonteiro anmonteiro force-pushed the anmonteiro/repro-7819 branch 2 times, most recently from f99973b to f8866f2 Compare June 5, 2023 21:02
@anmonteiro anmonteiro mentioned this pull request Jun 5, 2023
Merged
@anmonteiro anmonteiro force-pushed the anmonteiro/repro-7819 branch 3 times, most recently from b9f7e39 to 9216b4a Compare June 5, 2023 23:52
@anmonteiro anmonteiro marked this pull request as draft June 7, 2023 00:55
@anmonteiro
Copy link
Collaborator Author

I haven't been able to find a fix for this issue yet. Here's my current investigation:

  • in our test, ppx_deriving_runtime (public name other-ppx.runtime) appears in ppx_runtime_libraries for other-ppx.api, a regular library
  • the ppx other-ppx.eq is a ppx deriver, which then depends on other-ppx.api
  • other-ppx.api depends on (ppx_runtime_libraries ppx_deriving_runtime)
    • now, this ppx runtime library is resolved by the target context. but its transitive closure never reaches other-ppx.api since it was only reachable when we resolved the ppx from the host context

@anmonteiro anmonteiro force-pushed the anmonteiro/repro-7819 branch from 9216b4a to 079376b Compare June 9, 2023 01:09
@anmonteiro
Revert "Revert ocaml#7415 and ocaml#7450 (ocaml#7887)"
a1ac1e2 
This reverts commit 886df09.

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro anmonteiro force-pushed the anmonteiro/repro-7819 branch from 079376b to a1ac1e2 Compare June 9, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anmonteiro