Revert #7415 and #7450 #7887
Merged
Revert #7415 and #7450 #7887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…til context is known" This reverts commit ab74a71. Signed-off-by: Etienne Millon <me@emillon.org>
…px_runtime_libraries" This reverts commit 096fc97. Signed-off-by: Etienne Millon <me@emillon.org>
…ntext (ocaml#7415)" This reverts commit 16a7e88. Signed-off-by: Etienne Millon <me@emillon.org>
|
Discussed with @rgrinberg, @anmonteiro and confirmed to work by @samoht, so I'm merging this. |
emillon
added a commit
to emillon/dune
that referenced
this pull request
Jun 5, 2023
* Revert "fix(x-compilation): delay evaluation of `ppx_runtime_deps` until context is known" This reverts commit ab74a71. Signed-off-by: Etienne Millon <me@emillon.org> * Revert "test(x-compilation): demonstrate overlap check failure with ppx_runtime_libraries" This reverts commit 096fc97. Signed-off-by: Etienne Millon <me@emillon.org> * Revert "fix(x-compilation): find host ppx dependencies in the host context (ocaml#7415)" This reverts commit 16a7e88. Signed-off-by: Etienne Millon <me@emillon.org> * Changelog Signed-off-by: Etienne Millon <me@emillon.org> --------- Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
that referenced
this pull request
Jun 5, 2023
* Revert "fix(x-compilation): delay evaluation of `ppx_runtime_deps` until context is known" This reverts commit ab74a71. * Revert "test(x-compilation): demonstrate overlap check failure with ppx_runtime_libraries" This reverts commit 096fc97. * Revert "fix(x-compilation): find host ppx dependencies in the host context (#7415)" This reverts commit 16a7e88. * Changelog --------- Signed-off-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Jun 5, 2023
CHANGES: - Fix a crash when using a version of Coq < 8.13 due to the native compiler config variable being missing. We now explicitly default to `(mode vo)` for these older versions of Coq. (ocaml/dune#7847, fixes ocaml/dune#7846, @Alizter) - Duplicate installed Coq theories are now allowed with the first appearing in COQPATH being preferred. This is inline with Coq's loadpath semantics. This fixes an issue with install layouts based on COQPATH such as those found in nixpkgs. (ocaml/dune#7790, @Alizter) - Revert ocaml/dune#7415 and ocaml/dune#7450 (Resolve `ppx_runtime_libraries` in the target context when cross compiling) (ocaml/dune#7887, fixes ocaml/dune#7875, @emillon)
anmonteiro
added a commit
to anmonteiro/dune
that referenced
this pull request
Jun 5, 2023
This reverts commit 886df09.
This was referenced Jun 5, 2023
anmonteiro
added a commit
to anmonteiro/dune
that referenced
this pull request
Jun 5, 2023
This reverts commit 886df09. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
added a commit
to anmonteiro/dune
that referenced
this pull request
Jun 9, 2023
This reverts commit 886df09. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Jun 27, 2023
This reverts commit b566e50.
emillon
added a commit
to emillon/dune
that referenced
this pull request
Jun 28, 2023
…ocaml#7890)""" This reverts commit d7ee814.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ppx_runtime_depsuntil context is known"Fixes #7875