[new release] dune (15 packages) (3.8.1) #23884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: - Fix a crash when using a version of Coq < 8.13 due to the native compiler config variable being missing. We now explicitly default to `(mode vo)` for these older versions of Coq. (ocaml/dune#7847, fixes ocaml/dune#7846, @Alizter) - Duplicate installed Coq theories are now allowed with the first appearing in COQPATH being preferred. This is inline with Coq's loadpath semantics. This fixes an issue with install layouts based on COQPATH such as those found in nixpkgs. (ocaml/dune#7790, @Alizter) - Revert ocaml/dune#7415 and ocaml/dune#7450 (Resolve `ppx_runtime_libraries` in the target context when cross compiling) (ocaml/dune#7887, fixes ocaml/dune#7875, @emillon)
|
Is this a regression? |
|
No, it doesn't build with dune 3.7.0 either. |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Jun 6, 2023
spotted in revdeps for ocaml#23884
|
Thanks; it's helpful to submit constraint fixes for those kinds of things as you spot them if you get a chance, as it makes future CI runs more useful. I've done this one in #23888 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast, portable, and opinionated build system
CHANGES:
Fix a crash when using a version of Coq < 8.13 due to the native compiler
config variable being missing. We now explicitly default to
(mode vo)forthese older versions of Coq. (fix(coq): fix crash when COQ_NATIVE_COMPILER_DEFAULT missing dune#7847, fixes [Coq] Dune crashes on version 3.8 dune#7846, @Alizter)
Duplicate installed Coq theories are now allowed with the first appearing in
COQPATH being preferred. This is inline with Coq's loadpath semantics. This
fixes an issue with install layouts based on COQPATH such as those found in
nixpkgs. (coq: test and fix duplicate theory prefix in COQPATH bug dune#7790, @Alizter)
Revert fix(x-compilation): find host ppx dependencies in the host context dune#7415 and test(x-compilation): demonstrate overlap check failure with ppx_runtime_libraries dune#7450 (Resolve
ppx_runtime_librariesin the target context whencross compiling) (Revert #7415 and #7450 dune#7887, fixes 3.8.0 regression: Error: Library "ppx_deriving_runtime" not found. dune#7875, @emillon)