-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conf-qt: don't run a script that calls 'sudo add-apt-repository' #9915
Conversation
@yallop |
Yes, Travis is running Trusty nowadays, so the packages that were once missing may be directly installable now. |
It could even pass CI after your change .... |
It seems that |
From logs I can see that we don't have Qt5 installed on the GNU/Linux that uses There are also some issues with QOCamlBrowser but I will deal with them in #9924 |
ea38fa6
to
f6b8b86
Compare
Yes; neither alpine nor Centos have Qt5 available, as far I can see. |
Well, there is something https://pkgs.alpinelinux.org/package/edge/community/x86/qt5-qtbase But for me it will be easier to disable CIing of Qt related packages on these distro's (my heart belongs to .debs) |
65aa2f0
to
d2d96a0
Compare
d2d96a0
to
156713f
Compare
Well, qmake for qt5 is not found because it has different name in Alpine. https://pkgs.alpinelinux.org/contents?branch=edge&name=qt5-qtbase-dev&arch=ppc64le&repo=community I will try to get something useful from the Alpine Linux IRC..... |
@yallop It seems that on alpine we need to adjust PATH to successfully use Qt5 on alpine, like Of course, we can run this path adjustment for every platform and hope that it will work OK.... What do you think? |
@Kakadu: I think something like this might work:
|
I think os is the result of |
it seems that @dbuenzli is right |
@avsm Our minds have been diverged. Can you help us to constraint some opam commands to the linux version? The "os" variable corresponds to the output of |
I'm afraid it's hard to fix this without opam changes -- see ocaml/opam#2919 for the issue tracking the opam2 improvements in this regard. |
The
source linux
depext
script forconf-qt
is Ubuntu-specific:and has surprising and enduring effects on other systems (e.g. Debian). Removing this will probably make the CI fail, but is better for users.
/cc @Kakadu