Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf-qt: don't run a script that calls 'sudo add-apt-repository' #9915

Merged
merged 5 commits into from
Aug 1, 2017

Conversation

yallop
Copy link
Member

@yallop yallop commented Jul 24, 2017

The source linux depext script for conf-qt is Ubuntu-specific:

sudo add-apt-repository "deb http://archive.ubuntu.com/ubuntu trusty universe"
sudo add-apt-repository "deb http://archive.ubuntu.com/ubuntu trusty main"

and has surprising and enduring effects on other systems (e.g. Debian). Removing this will probably make the CI fail, but is better for users.

/cc @Kakadu

@Kakadu
Copy link
Contributor

Kakadu commented Jul 24, 2017

@yallop
If Ubuntu version on CI server is rather new (12.04 didn't have right packages in 2013) we can remove the script at all.

@yallop
Copy link
Member Author

yallop commented Jul 24, 2017

Yes, Travis is running Trusty nowadays, so the packages that were once missing may be directly installable now.

@Kakadu
Copy link
Contributor

Kakadu commented Jul 24, 2017

It could even pass CI after your change ....

@Kakadu
Copy link
Contributor

Kakadu commented Jul 24, 2017

It seems that qt5-qmake package is needed....

@Kakadu
Copy link
Contributor

Kakadu commented Jul 25, 2017

From logs I can see that we don't have Qt5 installed on the GNU/Linux that uses apk package manager.

There are also some issues with QOCamlBrowser but I will deal with them in #9924

@yallop yallop force-pushed the conf-qt-source-linux branch from ea38fa6 to f6b8b86 Compare July 25, 2017 11:13
@yallop
Copy link
Member Author

yallop commented Jul 25, 2017

From logs I can see that we don't have Qt5 installed on the GNU/Linux that uses apk package manager.

Yes; neither alpine nor Centos have Qt5 available, as far I can see.

@Kakadu
Copy link
Contributor

Kakadu commented Jul 25, 2017

Well, there is something https://pkgs.alpinelinux.org/package/edge/community/x86/qt5-qtbase

But for me it will be easier to disable CIing of Qt related packages on these distro's (my heart belongs to .debs)

@yallop yallop force-pushed the conf-qt-source-linux branch from 65aa2f0 to d2d96a0 Compare July 26, 2017 16:33
@yallop yallop force-pushed the conf-qt-source-linux branch from d2d96a0 to 156713f Compare July 26, 2017 16:37
@Kakadu
Copy link
Contributor

Kakadu commented Jul 27, 2017

Well, qmake for qt5 is not found because it has different name in Alpine. https://pkgs.alpinelinux.org/contents?branch=edge&name=qt5-qtbase-dev&arch=ppc64le&repo=community

I will try to get something useful from the Alpine Linux IRC.....

@avsm avsm merged commit a33d67a into ocaml:master Aug 1, 2017
@yallop yallop deleted the conf-qt-source-linux branch August 1, 2017 21:12
@Kakadu
Copy link
Contributor

Kakadu commented Aug 4, 2017

@yallop It seems that on alpine we need to adjust PATH to successfully use Qt5 on alpine, like set PATH= /usr/lib/qt5/bin/:$PATH. There is a small issue: I don't know how to make this command runnable only on alpine and manual entry doesn't help so much http://opam.ocaml.org/doc/Manual.html#Filters

Of course, we can run this path adjustment for every platform and hope that it will work OK.... What do you think?

@yallop
Copy link
Member Author

yallop commented Aug 4, 2017

@Kakadu: I think something like this might work:

build: [
    ["sh" "-exc" "PATH=/usr/lib/qt5/bin:$PATH echo \"Your Qt version is `qmake -query QT_VERSION`\"" ] 
       {os = "alpine"}
   …

@dbuenzli
Copy link
Contributor

dbuenzli commented Aug 4, 2017

{os = "alpine"}

I think os is the result of uname -s so I don't think that this will work.

@yallop
Copy link
Member Author

yallop commented Aug 4, 2017

I expect you're right, @dbuenzli, but in that case we have a few errors elsewhere in the repository, e.g. in sodium (cc @dsheets).

@Kakadu Kakadu mentioned this pull request Aug 4, 2017
@Kakadu
Copy link
Contributor

Kakadu commented Aug 4, 2017

it seems that @dbuenzli is right

@Kakadu
Copy link
Contributor

Kakadu commented Aug 9, 2017

@avsm Our minds have been diverged. Can you help us to constraint some opam commands to the linux version? The "os" variable corresponds to the output of uname command but we need output of lsb_release -i.

@avsm
Copy link
Member

avsm commented Aug 9, 2017

I'm afraid it's hard to fix this without opam changes -- see ocaml/opam#2919 for the issue tracking the opam2 improvements in this regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants