Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of qocamlbrowser and add new version #9924

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

Kakadu
Copy link
Contributor

@Kakadu Kakadu commented Jul 25, 2017

old version restricted to < 4.04
new one added

Inspired by #9915

@yallop
Copy link
Member

yallop commented Jul 27, 2017

The Travis job for OCaml 4.05.0 is failing to build lablqt.0.4:

# File "ppxext/ppx_qt.ml", line 246, characters 79-88:
# Error: This expression has type string but an expression was expected of type
#          Ast_helper.str = string Location.loc
# Command exited with code 2.

I've opened a separate PR (#9942) to fix the problem.

@avsm
Copy link
Member

avsm commented Aug 9, 2017

I think this is fine to merge now that #9915 has also been merged

@avsm avsm merged commit daeee23 into ocaml:master Aug 9, 2017
@Kakadu Kakadu deleted the fix-qocamlbrowser branch January 15, 2018 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants