Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to (lang dune 3.0) #6154

Closed
wants to merge 1 commit into from
Closed

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Aug 13, 2024

According to @rgrinberg:

Older dune doesn’t have proper support for directory targets, so stale artifact deletion would run and delete the contents of the directory

This is the case for make reftest-gen (aka. dune build @reftest-gen) which starts by deleting every opam roots and opam repositories in _build/default/tests/reftests previously created by make test, which makes that command take upwards of 70 seconds before actually running reftest-gen.
EDIT: Actually this is a separate issue fixed in #6155

Currently this PR does not work and makes every tests fail with:

[WARNING] No switch is currently set, perhaps you meant '--set-default'?
Fatal error:
/<path>/_build/default/src/client/opamMain.exe: "open" failed on
/tmp/build_ff9d44_dune/opam-reftest-7c8979/OPAM/repo/lock: Permission denied

and i have no idea why. Does anyone have an idea?

@kit-ty-kate kit-ty-kate changed the title Upgrade to (lang dune 3.0) to fix performance issues when calling "make reftest-gen" Upgrade to (lang dune 3.0) Aug 13, 2024
@kit-ty-kate
Copy link
Member Author

The original issue was fixed in #6155 so closing this. We'll see about the permission issue whenever we upgrade to (lang dune 3.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant