Speedup "make reftest-gen" #6155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
speedup-reftest-gen
branch
from
0cf6c63 to
eb9fec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening #6154 made me realised that the reason
make reftest-genis slow is that we're removingtests/reftests/dune.incwhich lists all the opam roots/opam repositories and tar.gz targets, so dune build will scan the directory and remove everything that it doesn't know about and given those targets are not defined anymore it will then remove everything.Simply not emptying that file fixes the issue. If in the future we need to upgrade the syntax or whatever we can always remove that file manually and the error message should make it obvious. But in the meantime this change is extremely beneficial to the day-to-day development setup by not having to remove then re-download, unpack and recreate 5GB everytime that rule is called